-
Notifications
You must be signed in to change notification settings - Fork 817
[20021] TCP support for Discovery server CLI and env. var. (backport #4097) #4135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Refs #20021: TCP support for CLI Discovery server Signed-off-by: cferreiragonz <[email protected]> * Refs #20021: Add TCP to Discovery Server Example Signed-off-by: cferreiragonz <[email protected]> * Refs #20021: CLI: Add argument for TCP port and example Signed-off-by: cferreiragonz <[email protected]> * Refs #20021: Add TCP support to environment variable Signed-off-by: cferreiragonz <[email protected]> * Refs #20021: Use autofill feature & check existing transports Signed-off-by: cferreiragonz <[email protected]> * Refs #20021: Update BlackboxTestsDiscovery for TCPv4/6 dns support Signed-off-by: cferreiragonz <[email protected]> * Refs #20021: Apply Revision's Suggestions Signed-off-by: cferreiragonz <[email protected]> * Refs #20021: Add test for TCP single IP address & Fix DNS test Signed-off-by: cferreiragonz <[email protected]> * Refs #20021: Add default TCP interface to CLI Signed-off-by: cferreiragonz <[email protected]> * Refs #20021: Uncrustify Signed-off-by: cferreiragonz <[email protected]> * Refs #20021: Update tests with new locator syntax & fix CLI Signed-off-by: cferreiragonz <[email protected]> * Refs #20021: Update Readme Signed-off-by: cferreiragonz <[email protected]> * Refs #20021: Fix warnings Signed-off-by: cferreiragonz <[email protected]> * Refs 20021: Update versions.md Signed-off-by: cferreiragonz <[email protected]> --------- Signed-off-by: cferreiragonz <[email protected]> (cherry picked from commit 2653efb) # Conflicts: # examples/C++/DDS/BasicConfigurationExample/BasicConfigurationPublisher.cpp # examples/C++/DDS/BasicConfigurationExample/BasicConfigurationSubscriber.cpp # examples/cpp/dds/DiscoveryServerExample/DiscoveryServerServer.cpp # examples/cpp/dds/DiscoveryServerExample/DiscoveryServer_main.cpp # examples/cpp/dds/DiscoveryServerExample/README.md # examples/cpp/dds/DiscoveryServerExample/arg_configuration.h # examples/cpp/dds/DiscoveryServerExample/common.h # include/fastdds/rtps/attributes/ServerAttributes.h # src/cpp/rtps/RTPSDomain.cpp # src/cpp/rtps/builtin/discovery/participant/PDPClient.cpp # test/blackbox/common/BlackboxTestsDiscovery.cpp # tools/fds/server.cpp # tools/fds/server.h # versions.md
13 tasks
Signed-off-by: cferreiragonz <[email protected]>
This reverts commit b79bbe9.
Signed-off-by: cferreiragonz <[email protected]>
62a0ad9
to
f0ca969
Compare
Signed-off-by: cferreiragonz <[email protected]>
MiguelCompany
requested changes
Dec 14, 2023
Signed-off-by: cferreiragonz <[email protected]>
Signed-off-by: cferreiragonz <[email protected]>
@richiprosima please test mac please test linux please test discovery_server please check style |
MiguelCompany
previously approved these changes
Dec 18, 2023
Signed-off-by: cferreiragonz <[email protected]>
MiguelCompany
previously approved these changes
Dec 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with green CI
Signed-off-by: cferreiragonz <[email protected]>
@richiprosima please test this |
MiguelCompany
approved these changes
Dec 21, 2023
@richiprosima Please test mac |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #4097 done by Mergify.
Cherry-pick of 2653efb has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refresh
will re-evaluate the rules@Mergifyio rebase
will rebase this PR on its base branch@Mergifyio update
will merge the base branch into this PR@Mergifyio backport <destination>
will backport this PR on<destination>
branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com