[19638] Fix clang warnings #3901
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ricardo González Moreno <[email protected]>
|
@Mergifyio backport 2.10.x 2.6.x |
✅ Backports have been created
|
Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
|
@richiprosima please test this |
|
@richiprosima Please test mac |
|
The specific test that have failed in MacOs is not modified in this PR. Nevertheless, it seems like its failing consistently with the same error. The warnings are fixed by this PR. |
MiguelCompany
approved these changes
Oct 6, 2023
mergify bot
pushed a commit
that referenced
this pull request
Oct 6, 2023
* Refs #18687. Fix warnings after upgrade clang Signed-off-by: Ricardo González Moreno <[email protected]> * Refs #19638: linters Signed-off-by: JLBuenoLopez-eProsima <[email protected]> --------- Signed-off-by: Ricardo González Moreno <[email protected]> Signed-off-by: JLBuenoLopez-eProsima <[email protected]> Co-authored-by: Ricardo González Moreno <[email protected]> (cherry picked from commit 462f5d7) # Conflicts: # test/unittest/xmlparser/XMLElementParserTests.cpp
mergify bot
pushed a commit
that referenced
this pull request
Oct 6, 2023
* Refs #18687. Fix warnings after upgrade clang Signed-off-by: Ricardo González Moreno <[email protected]> * Refs #19638: linters Signed-off-by: JLBuenoLopez-eProsima <[email protected]> --------- Signed-off-by: Ricardo González Moreno <[email protected]> Signed-off-by: JLBuenoLopez-eProsima <[email protected]> Co-authored-by: Ricardo González Moreno <[email protected]> (cherry picked from commit 462f5d7) # Conflicts: # examples/C++/RTPSTest_persistent/TestWriterPersistent.cpp # examples/C++/RTPSTest_registered/TestWriterRegistered.cpp # test/unittest/xmlparser/XMLElementParserTests.cpp
MiguelCompany
pushed a commit
that referenced
this pull request
Oct 6, 2023
* Fix clang warnings (#3901) * Refs #18687. Fix warnings after upgrade clang Signed-off-by: Ricardo González Moreno <[email protected]> * Refs #19638: linters Signed-off-by: JLBuenoLopez-eProsima <[email protected]> --------- Signed-off-by: Ricardo González Moreno <[email protected]> Signed-off-by: JLBuenoLopez-eProsima <[email protected]> Co-authored-by: Ricardo González Moreno <[email protected]> (cherry picked from commit 462f5d7) # Conflicts: # test/unittest/xmlparser/XMLElementParserTests.cpp * Fix conflicts Signed-off-by: JLBuenoLopez-eProsima <[email protected]> --------- Signed-off-by: JLBuenoLopez-eProsima <[email protected]> Co-authored-by: José Luis Bueno López <[email protected]> Co-authored-by: JLBuenoLopez-eProsima <[email protected]>
MiguelCompany
pushed a commit
that referenced
this pull request
Oct 9, 2023
* Fix clang warnings (#3901) * Refs #18687. Fix warnings after upgrade clang Signed-off-by: Ricardo González Moreno <[email protected]> * Refs #19638: linters Signed-off-by: JLBuenoLopez-eProsima <[email protected]> --------- Signed-off-by: Ricardo González Moreno <[email protected]> Signed-off-by: JLBuenoLopez-eProsima <[email protected]> Co-authored-by: Ricardo González Moreno <[email protected]> (cherry picked from commit 462f5d7) # Conflicts: # examples/C++/RTPSTest_persistent/TestWriterPersistent.cpp # examples/C++/RTPSTest_registered/TestWriterRegistered.cpp # test/unittest/xmlparser/XMLElementParserTests.cpp * Fix conflicts Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Linters Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19638: fix Mac warning Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19638: linters Signed-off-by: JLBuenoLopez-eProsima <[email protected]> --------- Signed-off-by: JLBuenoLopez-eProsima <[email protected]> Co-authored-by: José Luis Bueno López <[email protected]> Co-authored-by: JLBuenoLopez-eProsima <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR cherry-picks 9c76dcc into 2.11.x. This PR should be merged first into the branch before considering merging any other backport. MacOs CI is broken due to the warnings fixed in this PR.
@Mergifyio backport 2.10.x 2.6.x.
Contributor Checklist
versions.mdfile (if applicable).Reviewer Checklist