Skip to content

[16430] Fixing CMake for Fast-DDS use as submodule #3136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 9, 2022
Merged

[16430] Fixing CMake for Fast-DDS use as submodule #3136

merged 1 commit into from
Dec 9, 2022

Conversation

MiguelBarro
Copy link
Contributor

@MiguelBarro MiguelBarro commented Dec 7, 2022 •
edited
Loading

Description

Addresses issue: #3131

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • NA Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added.
  • NA Any new/modified methods have been properly documented using Doxygen.
  • Fast DDS test suite has been run locally.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • Documentation builds and tests pass locally.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.

Reviewer Checklist

  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@MiguelBarro MiguelBarro mentioned this pull request Dec 7, 2022
Closed
1 task
@MiguelBarro
Copy link
Contributor Author

@richiprosima Please test this for me 🤯

@MiguelBarro MiguelBarro self-assigned this Dec 7, 2022
@MiguelCompany MiguelCompany merged commit f0f8832 into master Dec 9, 2022
@MiguelCompany MiguelCompany deleted the bugfix/submodule_use branch December 9, 2022 08:40
@MiguelCompany
Copy link
Member

@MiguelBarro would you mind checking to which branches this should be backported?

@MiguelCompany MiguelCompany mentioned this pull request Dec 13, 2022
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

Assignees

@MiguelBarro MiguelBarro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MiguelBarro @MiguelCompany