Skip to content

[14093] Update ContentFilter test TypeObject using upcoming Fast DDS-Gen v2.1.2 #2576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 15, 2022

Conversation

JLBuenoLopez
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez commented Mar 14, 2022

Description

Upcoming release Fast DDS-Gen v2.1.2 introduces changes when generating the TypeObject. This PR uses this upcoming release changes to regenerate the TypeObject used in the ContentFilter tests.

Fast DDS repository includes some other TypeObjects related to the DynamicTypes and XTypes tests. These other TypeObjects have not been regenerated because Fast DDS-Gen issues errors and no output files are generated. These issues will be solved in the upcoming months when DDS-XTypes 1.3 full compliance is added (see #2575 where the roadmap is being updated).

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A The code follows the style guidelines of this project.

Code is autogenerated so the linters are not required to pass.

  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added.
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • Fast DDS test suite has been run locally.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • N/A Documentation builds and tests pass locally.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.

Reviewer Checklist

  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@JLBuenoLopez JLBuenoLopez added this to the v2.6.0 milestone Mar 14, 2022
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@JLBuenoLopez
Copy link
Contributor Author

CI failures are unrelated

@JLBuenoLopez JLBuenoLopez added the ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. label Mar 15, 2022
@MiguelCompany MiguelCompany merged commit 02ce904 into master Mar 15, 2022
@MiguelCompany MiguelCompany deleted the feature/update-type-objects-FastDDSGen-2.1.2 branch March 15, 2022 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants