Skip to content

Support XML config for fastdds-discovery-server [13783] #2498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

VictorMMaroto
Copy link
Contributor

@VictorMMaroto VictorMMaroto commented Feb 15, 2022

Documentation PR: eProsima/Fast-DDS-docs#351

Signed-off-by: Victor M Maroto [email protected]

@VictorMMaroto VictorMMaroto force-pushed the feature/SupportXMLconfigforfastdds-discovery-server branch 2 times, most recently from 37a9943 to 3086f35 Compare February 15, 2022 10:21
@richiware richiware changed the title Refs13783 - Support XML config for fastdds-discovery-server Support XML config for fastdds-discovery-server [13783] Feb 21, 2022
@JLBuenoLopez JLBuenoLopez added the doc-pending Issue or PR which is pending to be documented label Mar 2, 2022
@JLBuenoLopez JLBuenoLopez force-pushed the feature/SupportXMLconfigforfastdds-discovery-server branch 2 times, most recently from ae483ee to cd24262 Compare March 2, 2022 14:49
@JLBuenoLopez JLBuenoLopez force-pushed the feature/SupportXMLconfigforfastdds-discovery-server branch from cd24262 to ca8c4ba Compare March 3, 2022 06:44
Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
@JLBuenoLopez JLBuenoLopez removed the doc-pending Issue or PR which is pending to be documented label Mar 8, 2022
@JLBuenoLopez
Copy link
Contributor

CI failures are unrelated

Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from my comments below, it is shocking for me that the profile name is specified after the @. On HTTP URIs, the username is specified with http://username@host/

@EduPonz EduPonz added this to the v2.6.0 milestone Mar 11, 2022
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one change and we are good to go.

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MiguelCompany
Copy link
Member

@JLBuenoLopez-eProsima Two of the new tests failed on aarch64

@MiguelCompany
Copy link
Member

@richiprosima Please test aarch64

@MiguelCompany MiguelCompany merged commit ee8f5d2 into master Mar 14, 2022
@MiguelCompany MiguelCompany deleted the feature/SupportXMLconfigforfastdds-discovery-server branch March 14, 2022 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants