-
Notifications
You must be signed in to change notification settings - Fork 824
Support XML config for fastdds-discovery-server [13783] #2498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support XML config for fastdds-discovery-server [13783] #2498
Conversation
37a9943
to
3086f35
Compare
Signed-off-by: Victor M Maroto <[email protected]>
ae483ee
to
cd24262
Compare
Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
cd24262
to
ca8c4ba
Compare
Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
CI failures are unrelated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from my comments below, it is shocking for me that the profile name is specified after the @
. On HTTP URIs, the username is specified with http://username@host/
…nstexpr. Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
…nt and add test Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one change and we are good to go.
Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@JLBuenoLopez-eProsima Two of the new tests failed on aarch64 |
@richiprosima Please test aarch64 |
Documentation PR: eProsima/Fast-DDS-docs#351
Signed-off-by: Victor M Maroto [email protected]