Skip to content

[13780] Fix dynamic network interfaces #2468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Feb 11, 2022

Conversation

JLBuenoLopez
Copy link
Contributor

This PR fixes the dynamic network interfaces feature.

@JLBuenoLopez JLBuenoLopez linked an issue Feb 7, 2022 that may be closed by this pull request
@JLBuenoLopez JLBuenoLopez added this to the v2.5.1 milestone Feb 7, 2022
@JLBuenoLopez JLBuenoLopez changed the title [13545] Fix dynamic network interfaces [13780] Fix dynamic network interfaces Feb 7, 2022
@JLBuenoLopez
Copy link
Contributor Author

CI failures seem unrelated

@MiguelCompany MiguelCompany self-requested a review February 9, 2022 13:36
… in case of new interfaces

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
…dp_localhost_multi blackbos test

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
@JLBuenoLopez JLBuenoLopez force-pushed the bugfix/dynamic-network-interface branch from 730b114 to 0a6a03e Compare February 10, 2022 14:59
@MiguelCompany MiguelCompany changed the base branch from 2.5.x to master February 10, 2022 15:03
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JLBuenoLopez
Copy link
Contributor Author

@richiprosima please test windows

@JLBuenoLopez
Copy link
Contributor Author

Windows warnings are solved in #2487. Other CI failures are unrelated

@MiguelCompany MiguelCompany merged commit b27cfbb into master Feb 11, 2022
@MiguelCompany MiguelCompany deleted the bugfix/dynamic-network-interface branch February 11, 2022 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to use dynamic network interfaces ? [13545]
2 participants