Fix inserting minimum CacheChange_t in GAP message [13671] #2448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ricardo González Moreno <[email protected]>
richiware
changed the title
MiguelCompany
requested changes
Jan 31, 2022
Signed-off-by: Ricardo González Moreno <[email protected]>
|
@Mergifyio backport 2.4.x |
🟠 Waiting for conditions to match
|
mergify bot
pushed a commit
that referenced
this pull request
Feb 4, 2022
* Refs #13556. Fix bug when history's min seq is irrelevant Signed-off-by: Ricardo González Moreno <[email protected]> * Refs #13556. Add regression test. Signed-off-by: Ricardo González Moreno <[email protected]> (cherry picked from commit df8dfde)
✅ Backports have been created
|
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug which occurs when the
CacheChange_twith minimum sequence number in the Writer's history is irrelevant for a new reader (for example because reader is volatile). This change is not added in the GAP message because of a>instead of a>=.