Move libp11 dependency to tests only #2381
Conversation
…he library dynamically through the OpenSSL engine. Signed-off-by: Miguel Barro <[email protected]>
MiguelBarro
force-pushed
the
backport/master/bugfix/windows_installer/static_linking
branch
from
26a88f0 to
d978d30
Compare
There was a problem hiding this comment.
It seems target_link_libraries also adds the include directory of the linked target, so removing it is making the build fail with Cannot open include file: 'libp11.h': No such file or directory (compiling source file C:\workspace\fastdds-manual-windows\b64998d6\src\fastrtps\src\cpp\rtps\security\SecurityPluginFactory.cpp)
I wonder why it is building correctly on other platforms, though.
|
The problem is in the jenkins windows image. I will relaunch the windows testing once it is fixed. |
|
@richiprosima Please darling be so gentle to test Windows for me 😎 |
Signed-off-by: Miguel Barro <[email protected]>
Signed-off-by: Miguel Barro <[email protected]>
…orkspace. Signed-off-by: Miguel Barro <[email protected]>
|
@richiprosima Please test Mac to check if I installed libp11 correctly |
Signed-off-by: Miguel Barro <[email protected]>
|
@richiprosima Please test Mac again because we have modified CI's setup since the last push 🛠 |
|
@richiprosima Please test Mac and test Windows |
|
@richiprosima Please test Mac |
MiguelCompany
changed the title
MiguelCompany
deleted the
backport/master/bugfix/windows_installer/static_linking
branch
CMake always makes static libraries transitive targets even if they are marked as PRIVATE, that is, CMake will never bundle Fast-DDS static library with OpenSSL, tinyxml or pkcs11.
People have found ways to work around it through custom CMake commands see here.
We took an easier workaround on the third parties by including the actual sources into the Fast-DDS project.
The Bugfix plainly removes the Fast-DDS dependency because it's only useful on the tests. Note the OpenSSL engine loads the pkcs11 module dynamically thus no linking is required.