Separate initialization and enabling of BuiltinProtocols [12388] #2171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richiware
changed the title
MiguelCompany
requested changes
Oct 14, 2021
MiguelCompany
requested changes
Jan 3, 2022
richiware
force-pushed
the
feature/12355
branch
from
03d3eed to
0e427da
Compare
Signed-off-by: Ricardo González Moreno <[email protected]> Signed-off-by: Ricardo González <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]> Signed-off-by: Ricardo González <[email protected]>
Ensure good behaviour with static discovery, calling first for participant and later for endpoints. Signed-off-by: Ricardo González Moreno <[email protected]> Signed-off-by: Ricardo González <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]> Signed-off-by: Ricardo González <[email protected]>
Signed-off-by: Ricardo González <[email protected]>
Co-authored-by: Miguel Company <[email protected]> Signed-off-by: Ricardo González <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]> Signed-off-by: Ricardo González <[email protected]>
Co-authored-by: Miguel Company <[email protected]> Signed-off-by: Ricardo González <[email protected]>
richiware
force-pushed
the
feature/12355
branch
from
0e427da to
701f308
Compare
|
@richiprosima test this |
|
@richiprosima please test this |
|
CI failures seem unrelated (aarch64 has not run) |
JLBuenoLopez
added
the
ready-to-merge
|
Maybe it should be considered if this PR should be moved to |
|
@richiprosima Please test this |
|
CI failures seem unrelated. Ready to merge! |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to improve bandwidth network when using Static Discovery. Currently when the
RTPSParticipantis created, BuiltinProtocols are initialized and enabled at same time. Using Static Discovery provokes each time a DDS entity is enabled a new DATA(p) is sent adding this entity into the property list.With this PR the enabling of BuiltinProtocols is done after the enabling of DDS entities. Using Static Discovery only one DATA(p) is sent with all entities information.