Skip to content

Use ftruncate on QNX <master> #1773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 22, 2021
Merged

Conversation

MiguelCompany
Copy link
Member

This should fix #1765

Signed-off-by: Miguel Company <[email protected]>
@MiguelCompany MiguelCompany added the no-test Skip CI tests if PR marked with this label label Feb 19, 2021
@MiguelCompany
Copy link
Member Author

@richiprosima Please test this.

@richiprosima
Copy link
Contributor

Build status:

  • Linux Build Status
  • Linux aarch64Build Status
  • Mac Build Status
  • Windows Build Status

@asobhy-qnx
Copy link
Contributor

Can we add to 2.0.x and 2.1.x

Signed-off-by: Miguel Company <[email protected]>
@MiguelCompany MiguelCompany changed the title Use ftruncate on QNX Use ftruncate on QNX <master> Feb 19, 2021
@MiguelCompany
Copy link
Member Author

Can we add to 2.0.x and 2.1.x

We will cherry-pick after merging into master

@richiprosima
Copy link
Contributor

richiprosima commented Feb 19, 2021

Build status:

  • Linux Build Status
  • Linux aarch64Build Status
  • Mac Build Status
  • Windows Build Status

Copy link
Contributor

@IkerLuengo IkerLuengo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MiguelCompany MiguelCompany merged commit 2bb0610 into master Feb 22, 2021
@MiguelCompany MiguelCompany deleted the hotfix/use-ftruncate-on-qnx branch February 22, 2021 06:39
MiguelCompany added a commit that referenced this pull request Feb 22, 2021
* Use ftruncate on QNX

Signed-off-by: Miguel Company <[email protected]>

* Fixed warning.

Signed-off-by: Miguel Company <[email protected]>
MiguelCompany added a commit that referenced this pull request Feb 22, 2021
* Use ftruncate on QNX

Signed-off-by: Miguel Company <[email protected]>

* Fixed warning.

Signed-off-by: Miguel Company <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-test Skip CI tests if PR marked with this label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

posix_fallocate does not work on shared memory on QNX
4 participants