Skip to content

Introduce new LoanableTypedCollection interface [10479] #1731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 5, 2021

Conversation

MiguelCompany
Copy link
Member

Joining code duplicated on LoanableSequence and StackAllocatedSequence.

This would allow using LoanableTypedCollection<T> when we implement type-safe readers and writers, as well as using a StackAllocatedSequence<SampleInfo> on internal code where we now use a SampleInfoSeq

@MiguelCompany MiguelCompany force-pushed the feature/type-safe-interfaces/sequences branch from 850f96b to 053b956 Compare February 3, 2021 06:57
@MiguelCompany MiguelCompany changed the title Introduce new LoanableTypedCollection interface Introduce new LoanableTypedCollection interface [10479] Feb 3, 2021
@eProsima eProsima deleted a comment from richiware Feb 3, 2021
IkerLuengo
IkerLuengo previously approved these changes Feb 3, 2021
Copy link
Contributor

@IkerLuengo IkerLuengo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Linux aarch64Build Status
  • Mac Build Status
  • Windows Build Status

Signed-off-by: Miguel Company <[email protected]>
IkerLuengo
IkerLuengo previously approved these changes Feb 3, 2021
Copy link
Contributor

@IkerLuengo IkerLuengo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Linux aarch64Build Status
  • Mac Build Status
  • Windows Build Status

Copy link
Contributor

@IkerLuengo IkerLuengo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@richiware
Copy link
Member

richiware commented Feb 4, 2021

Build status:

  • Linux Build Status
  • Linux aarch64Build Status
  • Mac Build Status
  • Windows Build Status

Known failures. Aarch64 failed due to a CI infrastructure glitch. Nevertheless testing will be repeated when #1732 is rebased on top of this one.

@MiguelCompany MiguelCompany merged commit bd82800 into master Feb 5, 2021
@MiguelCompany MiguelCompany deleted the feature/type-safe-interfaces/sequences branch February 5, 2021 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants