-
Notifications
You must be signed in to change notification settings - Fork 821
Introduce new LoanableTypedCollection interface [10479] #1731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
850f96b
to
053b956
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏼
Signed-off-by: Miguel Company <[email protected]>
4221115
to
d2a1fd6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Miguel Company <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏼
Build status: Known failures. Aarch64 failed due to a CI infrastructure glitch. Nevertheless testing will be repeated when #1732 is rebased on top of this one. |
Joining code duplicated on
LoanableSequence
andStackAllocatedSequence
.This would allow using
LoanableTypedCollection<T>
when we implement type-safe readers and writers, as well as using aStackAllocatedSequence<SampleInfo>
on internal code where we now use aSampleInfoSeq