RobustInterprocessCondition implementation <1.10.x> [8213] #1147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build status:
|
|
Build status:
|
This was referenced Apr 16, 2020
|
Build status:
|
adolfomarver
force-pushed
the
feature/shared-memory/transport-robust-cv
branch
from
3b7e228 to
cfc8a18
Compare
Signed-off-by: AdolfoMartinez <[email protected]>
Signed-off-by: AdolfoMartinez <[email protected]>
Signed-off-by: AdolfoMartinez <[email protected]>
Signed-off-by: AdolfoMartinez <[email protected]>
Signed-off-by: AdolfoMartinez <[email protected]>
adolfomarver
force-pushed
the
feature/shared-memory/transport-robust-cv
branch
from
6b60096 to
82039da
Compare
|
Build status:
|
adolfomarver
force-pushed
the
feature/shared-memory/transport-robust-cv
branch
from
7928740 to
ba60423
Compare
|
Build status:
|
MiguelCompany
requested changes
Apr 20, 2020
src/cpp/rtps/transport/shared_mem/RobustInterprocessCondition.hpp
Outdated
Show resolved
Hide resolved
src/cpp/rtps/transport/shared_mem/RobustInterprocessCondition.hpp
Outdated
Show resolved
Hide resolved
src/cpp/rtps/transport/shared_mem/RobustInterprocessCondition.hpp
Outdated
Show resolved
Hide resolved
src/cpp/rtps/transport/shared_mem/RobustInterprocessCondition.hpp
Outdated
Show resolved
Hide resolved
|
Build status:
|
Signed-off-by: AdolfoMartinez <[email protected]>
adolfomarver
force-pushed
the
feature/shared-memory/transport-robust-cv
branch
from
36c0696 to
f99550a
Compare
Signed-off-by: AdolfoMartinez <[email protected]>
Signed-off-by: AdolfoMartinez <[email protected]>
adolfomarver
force-pushed
the
feature/shared-memory/transport-robust-cv
branch
from
f99550a to
1e5bd2c
Compare
MiguelCompany
approved these changes
Apr 20, 2020
|
Build status:
|
MiguelCompany
pushed a commit
that referenced
this pull request
Apr 21, 2020
* Refs #8212. RobustInterprocessCondition implementation. Signed-off-by: AdolfoMartinez <[email protected]> * Refs #8212. Condition tests. Signed-off-by: AdolfoMartinez <[email protected]> * Refs #8183. Bad SHM structures alignment in some platforms. Signed-off-by: AdolfoMartinez <[email protected]> * Refs #8212. nullptr check. Signed-off-by: AdolfoMartinez <[email protected]> * Refs #8212. Re-enable Liveliness tests. Signed-off-by: AdolfoMartinez <[email protected]> * Refs #8212. SHM ABI v3. Signed-off-by: AdolfoMartinez <[email protected]> * Refs #8212. Fix cmake error & set SHM_DEFAULT_TRANSPORT=OFF. Signed-off-by: AdolfoMartinez <[email protected]> * Refs #8212. FIFO strategy in condition notify. Signed-off-by: AdolfoMartinez <[email protected]>
MiguelCompany
added a commit
that referenced
this pull request
Apr 22, 2020
* RobustInterprocessCondition implementation (#1147) * Refs #8212. RobustInterprocessCondition implementation. Signed-off-by: AdolfoMartinez <[email protected]> * Refs #8212. Condition tests. Signed-off-by: AdolfoMartinez <[email protected]> * Refs #8183. Bad SHM structures alignment in some platforms. Signed-off-by: AdolfoMartinez <[email protected]> * Refs #8212. nullptr check. Signed-off-by: AdolfoMartinez <[email protected]> * Refs #8212. Re-enable Liveliness tests. Signed-off-by: AdolfoMartinez <[email protected]> * Refs #8212. SHM ABI v3. Signed-off-by: AdolfoMartinez <[email protected]> * Refs #8212. Fix cmake error & set SHM_DEFAULT_TRANSPORT=OFF. Signed-off-by: AdolfoMartinez <[email protected]> * Refs #8212. FIFO strategy in condition notify. Signed-off-by: AdolfoMartinez <[email protected]> * SHM Buffer recovery mechanishm (#1159) * Refs #8219. Change BufferNode to pre-allocated pool with fixed addresses for the nodes during entire life-cycle. Signed-off-by: AdolfoMartinez <[email protected]> * Refs #8219. SHM Buffer invalidation implementation. Signed-off-by: AdolfoMartinez <[email protected]> * Refs #8219. logWarning -> logInfo when segment overflow. Signed-off-by: AdolfoMartinez <[email protected]> * Refs #8219. Optimization. Signed-off-by: AdolfoMartinez <[email protected]> * Refs #8219. Style changes. Signed-off-by: AdolfoMartinez <[email protected]> * Refs #8219. buffer_recover test. Signed-off-by: AdolfoMartinez <[email protected]> * Refs #8219. 'error:' string removed from log msg. Signed-off-by: AdolfoMartinez <[email protected]> * Setting shared memory on by default. Signed-off-by: Miguel Company <[email protected]> * Fix build fail in ROS-CI. Signed-off-by: AdolfoMartinez <[email protected]> * Fix SHM uncaught exceptions. Signed-off-by: AdolfoMartinez <[email protected]> * Refs #8132 Fix DDS unittests to delete entities before exiting Signed-off-by: Laura Martin <[email protected]> * Disable PSM unittests Signed-off-by: Laura Martin <[email protected]> * Fix boost::interprocess::semaphore initialization. Signed-off-by: AdolfoMartinez <[email protected]> * Fix CXX_STANDARD on boost try_compile Co-authored-by: AdolfoMartinez <[email protected]> Co-authored-by: AdolfoMartinez <[email protected]> Co-authored-by: Laura Martin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves several SHM issues of v1.10.0
POSIX condition_variables are not robust for interprocess comunication. glibc issue
A robust interprocess_condition is implemented based on semaphores.
This should fix FastRTPS issue Application hangs when trying to create a participant #1144
SHM structures alignment is bad for some platforms provoking bus exceptions accesing atomics in shared memory. Also processes running in the same host compiled for different architectures (32/64-bit) failed to communicate.
This should fix issue FastRTPS Bus error with fastrtps 1.10 [8298] #1133
Signed-off-by: AdolfoMartinez [email protected]