1.9.x branch is failing after #918 [7595]

[ivanpauno]

Expected Behavior

It should build.

Current Behavior

It's broken since d1d7605.
Here the linker failures: https://ci.ros2.org/job/ci_linux/9315/console#console-section-31.

Steps to Reproduce

Build ros2, using master repos.

System information

• Fast-RTPS version: 1.9.x
• OS: Ubuntu 18.04
• Network interfaces:
  
• ROS2: Foxy (master)
  

Additional context

Seems that #918 triggered the problem.

Additional resources

• Wireshark capture
• XML profiles file

[MiguelCompany]

It seems the compiler is inlining the template method EDPSimple::serialize_proxy_data when built on release. Our CI builds are rel-with-deb-info, and thus didn't fail. I have checked that adding __attribute__((noinline)) to the said method fixes the issue. Even though, I would like to have a compiler agnostic solution

[MiguelCompany]

@ivanpauno I have just created PR #1009 that fixes this

[MiguelCompany]

@ivanpauno PR #1009 has just been merged. I have checked locally that building following the same steps as on https://ci.ros2.org/job/ci_linux/9315/console#console-section-31 with --packages-up-to fastrtps yields no error.

[ivanpauno]

Thanks for fixing the issue @MiguelCompany !

[mjcarroll]

Test build through our CI to verify.

• Linux
• Linux-aarch64
• macOS
• Windows
• Windows-container