Skip to content

Extend DISCOVERY_TOPIC to include physical information [14006] #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 9, 2022

Conversation

EduPonz
Copy link

@EduPonz EduPonz commented Mar 8, 2022

This PR documents eProsima/Fast-DDS#2549

@EduPonz EduPonz removed the skip-ci Automatically pass CI label Mar 9, 2022
@EduPonz EduPonz marked this pull request as ready for review March 9, 2022 08:38
@EduPonz
Copy link
Author

EduPonz commented Mar 9, 2022

@richiprosima please test this

@JLBuenoLopez JLBuenoLopez added this to the 2.6.0 milestone Mar 9, 2022
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a couple of nitpicks

Signed-off-by: Eduardo Ponz <[email protected]>
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EduPonz EduPonz merged commit 217eec2 into master Mar 9, 2022
@EduPonz EduPonz deleted the feature/statistics/extend_discovered_entity branch March 9, 2022 15:41
@EduPonz EduPonz mentioned this pull request Mar 10, 2022
xander-m2k pushed a commit to xander-m2k/Fast-DDS-docs that referenced this pull request Mar 11, 2022
* Refs 14006: Recommend PREALLOCATED_WITH_REALLOC_MEMORY_MODE for statistics DataReaders

Signed-off-by: Eduardo Ponz <[email protected]>

* Refs 14006: Document configuration of physical properties

Signed-off-by: Eduardo Ponz <[email protected]>

* Refs 14006: Apply suggestions

Signed-off-by: Eduardo Ponz <[email protected]>
Signed-off-by: Xander Moerkerken <[email protected]>
xander-m2k pushed a commit to xander-m2k/Fast-DDS-docs that referenced this pull request Mar 11, 2022
* Refs 14006: Recommend PREALLOCATED_WITH_REALLOC_MEMORY_MODE for statistics DataReaders

Signed-off-by: Eduardo Ponz <[email protected]>

* Refs 14006: Document configuration of physical properties

Signed-off-by: Eduardo Ponz <[email protected]>

* Refs 14006: Apply suggestions

Signed-off-by: Eduardo Ponz <[email protected]>
Signed-off-by: Xander Moerkerken <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants