Skip to content

[22721] Increase 'max_blocking_time' in Easy Mode #1024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 3, 2025
Merged

[22721] Increase 'max_blocking_time' in Easy Mode #1024

merged 2 commits into from
Feb 3, 2025

Conversation

cferreiragonz
Copy link
Contributor

@cferreiragonz cferreiragonz commented Jan 30, 2025 •
edited by juanlofer-eprosima
Loading

Description

This PR adds an explanatory note to detail the behavior of the service XML profile loaded automatically by Fast DDS (if ROS2_EASY_MODE is enabled) and how it will behave in case the user has its own XML profile defined.

Merge after:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A Code snippets related to the added documentation have been provided.
  • Documentation tests pass locally.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • CI passes without warnings or errors.

@cferreiragonz cferreiragonz added this to the v3.2.0 milestone Jan 30, 2025
@cferreiragonz cferreiragonz mentioned this pull request Jan 30, 2025
Merged
11 tasks
@cferreiragonz
Refs #22721: NIT
44204f5 
Signed-off-by: cferreiragonz <[email protected]>
@cferreiragonz cferreiragonz requested review from juanlofer-eprosima and removed request for MiguelCompany February 3, 2025 08:18
juanlofer-eprosima
juanlofer-eprosima approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@juanlofer-eprosima juanlofer-eprosima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juanlofer-eprosima juanlofer-eprosima merged commit d2ff5c3 into master Feb 3, 2025
4 checks passed
@juanlofer-eprosima juanlofer-eprosima deleted the increase_mbt_easy_mode branch February 3, 2025 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanlofer-eprosima juanlofer-eprosima juanlofer-eprosima approved these changes

Assignees
No one assigned
Labels
ci-pending
Projects
None yet
Milestone
v3.2.0 - Frozen ❄️
Development

Successfully merging this pull request may close these issues.
2 participants
@cferreiragonz @juanlofer-eprosima