Skip to content

[22056] Transform locators using new host_id PID #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 18, 2024
Merged

[22056] Transform locators using new host_id PID #107

merged 2 commits into from
Nov 18, 2024

Conversation

cferreiragonz
Copy link
Contributor

@cferreiragonz cferreiragonz commented Nov 6, 2024 •
edited
Loading

Description

This PR includes a test for a bug in which a TCP client connecting to localhost is unable to identify the locator of a TCP discovery server with a custom GUID listening on any.
Depends on:

@Mergifyio backport 1.2.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The added tests pass locally.
  • Changes are backwards compatible.
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@cferreiragonz cferreiragonz mentioned this pull request Nov 6, 2024
Merged
13 tasks
@MiguelCompany MiguelCompany self-requested a review November 18, 2024 08:56
@MiguelCompany MiguelCompany added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending labels Nov 18, 2024
@cferreiragonz cferreiragonz merged commit 5777caa into master Nov 18, 2024
5 of 7 checks passed
@cferreiragonz cferreiragonz deleted the feature/pid_host_id_to_parameterTypes branch November 18, 2024 09:43
@cferreiragonz
Copy link
Contributor Author

@Mergifyio backport 1.2.x

@mergify Mergify
Copy link

mergify bot commented Nov 18, 2024 •
edited
Loading

backport 1.2.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 18, 2024
@cferreiragonz @mergify
Transform locators using new host_id PID (#107)
b4e7132 
* Refs #22056: Typo in comment

Signed-off-by: cferreiragonz <[email protected]>

* Refs #22056: TCP-DS host_id test

Signed-off-by: cferreiragonz <[email protected]>

---------

Signed-off-by: cferreiragonz <[email protected]>
(cherry picked from commit 5777caa)

# Conflicts:
#	test/CMakeLists.txt
#	test/configuration/test_cases/test_95_tcpv4_cli.xml
#	test/configuration/test_cases/test_96_tcpv6_cli.xml
#	test/configuration/test_cases/test_97_tcpv4_env_var.xml
#	test/configuration/test_cases/test_98_tcpv6_env_var.xml
@mergify mergify bot mentioned this pull request Nov 18, 2024
Merged
9 tasks
cferreiragonz added a commit that referenced this pull request Nov 18, 2024
@cferreiragonz
Bp #107: TCP tests
c2cfb0f 
Signed-off-by: cferreiragonz <[email protected]>
cferreiragonz added a commit that referenced this pull request Dec 20, 2024
@mergify @cferreiragonz
Transform locators using new host_id PID (backport #107) (#108) & Add…
67785d5 
… TCP tests

* Bp #107: TCP tests

Signed-off-by: cferreiragonz <[email protected]>

* Fix TCP tests in 1.2.x

Signed-off-by: cferreiragonz <[email protected]>

---------

Signed-off-by: cferreiragonz <[email protected]>
Co-authored-by: cferreiragonz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

Assignees
No one assigned
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cferreiragonz @MiguelCompany