Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add logging tester to blackboxes #131

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add logging tester to blackboxes #131

wants to merge 1 commit into from

Conversation

jparisu
Copy link
Contributor

@jparisu jparisu commented Jan 26, 2022

Signed-off-by: jparisu [email protected]

juanlofer-eprosima
juanlofer-eprosima requested changes Jan 27, 2022
View reviewed changes
Copy link
Contributor

@juanlofer-eprosima juanlofer-eprosima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix ImplementationsTest.all_implementations by setting different GUIDs for LocalDiscoveryServer and WAN participants. Perhaps using different addresses is also required.

@jparisu jparisu marked this pull request as draft February 1, 2022 07:27
@jparisu
Copy link
Contributor Author

jparisu commented Feb 1, 2022 •
edited
Loading

This PR is blocked until warnings in Fast DDS are fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanlofer-eprosima juanlofer-eprosima juanlofer-eprosima requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jparisu @juanlofer-eprosima