New docker setup for emission-server #618
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
shankari
requested changes
Dec 4, 2018
docker/Dockerfile-base
Outdated
| @@ -0,0 +1,31 @@ | |||
| # python 3 | |||
| FROM continuumio/anaconda3 | |||
There was a problem hiding this comment.
This file doesn't include the changes to the Dockerfile in
#594
This is probably because you split the Dockerfile into two so the changes to Dockerfile were not merged into Dockerfile-base. Please merge the changes manually.
Also, as I pointed out in #617 (comment), after the change to miniconda, the server image is only 2GB. So I would recommend keeping one image for consistency but I will not oppose two images.
shankari
requested changes
Dec 5, 2018
| restart_policy: | ||
| condition: on-failure | ||
| ports: | ||
| - "27017:27017" |
There was a problem hiding this comment.
this is only if you want to access the DB from the host. Add a note to that effect?
shankari
requested changes
Dec 21, 2018
shankari
approved these changes
Dec 21, 2018
jf87
pushed a commit
to jf87/e-mission-server
that referenced
this pull request
Jun 21, 2021
* Resolve conflict in start_script.sh * Resolve conflict in Dockerfile * Add composefile * Update docker README.md and Dockerfile * Update README * Moved everything into Dockerfile and deleted Dockerfile-base * Add Maintainer * Mount volume to store db data by default * Pull from emssion-server repo and install Vim
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.