Fix DWaveCliqueSampler sometimes creating biases out of range
#572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #572 +/- ##
==========================================
- Coverage 89.05% 86.34% -2.72%
==========================================
Files 21 21
Lines 1892 1904 +12
==========================================
- Hits 1685 1644 -41
- Misses 207 260 +53 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
wbernoudy
approved these changes
May 16, 2025
randomir
reviewed
May 16, 2025
| @@ -36,8 +36,10 @@ class _QubitCouplingComposite(dimod.ComposedSampler): | |||
| sampler (:obj:`~dimod.ComposedSampler`): | |||
| A dimod sampler. | |||
| """ | |||
| def __init__(self, child_sampler): | |||
| def __init__(self, child_sampler, linear_range, quadratic_range): | |||
There was a problem hiding this comment.
New args should probably be documented, for consistency, since we already have docs on this private class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.