-
Notifications
You must be signed in to change notification settings - Fork 65
Add support for context manager protocol to all samplers #556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for context manager protocol to all samplers #556
Conversation
eda0233
to
fabf8ac
Compare
fabf8ac
to
cfb40b2
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #556 +/- ##
==========================================
- Coverage 88.79% 85.40% -3.40%
==========================================
Files 21 21
Lines 1669 1692 +23
==========================================
- Hits 1482 1445 -37
- Misses 187 247 +60 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Joel Pasvolsky <[email protected]>
Now all of QPU (
DWaveSampler
,DWaveCliqueSampler
), and hybrid (LeapHybrid*Sampler
) samplers support.close()
and runtime context use.Close #91.
Composites will be addressed in a follow-up as per #555.