Skip to content

chore(ci): update test.yml to include CH versions 24.11, 24.12, 25.1, 25.2, and 25.3 #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2025

Conversation

duyet
Copy link
Owner

@duyet duyet commented Apr 11, 2025

Summary by Sourcery

CI:

  • Add support for testing with ClickHouse versions 24.11, 24.12, 25.1, 25.2, and 25.3 in the GitHub Actions workflow

Copy link

vercel bot commented Apr 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clickhouse-monitoring ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 11, 2025 5:29am

Copy link
Contributor

sourcery-ai bot commented Apr 11, 2025

Reviewer's Guide by Sourcery

This pull request updates the ClickHouse versions used in the test.yml workflow file. The workflow now includes versions 24.11, 24.12, 25.1, 25.2, and 25.3 for testing.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
The ClickHouse versions used in the workflow have been updated to include newer releases.
  • Added ClickHouse versions 24.11, 24.12, 25.1, 25.2, and 25.3 to the test matrix.
  • The added versions are used in both the main test job and the TSAN test job.
.github/workflows/test.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Apr 11, 2025
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @duyet - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider using a matrix strategy to avoid repeating the same configuration for different ClickHouse versions.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Review instructions: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov-commenter
Copy link

Bundle Report

Bundle size has no change ✅

Affected Assets, Files, and Routes:

view changes for bundle: clickhouse-monitoring-bundle-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
server/middleware-*.js -752 bytes 170 bytes -81.56%
server/middleware-*.js 752 bytes 922 bytes 442.35% ⚠️
static/q53J9Qgb67XiLt2Y-*.js (New) 77 bytes 77 bytes 100.0% 🚀
static/q53J9Qgb67XiLt2Y-*.js (New) 813 bytes 813 bytes 100.0% 🚀
static/dH0SeAQHnu-*.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
static/dH0SeAQHnu-*.js (Deleted) -813 bytes 0 bytes -100.0% 🗑️

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.82%. Comparing base (fa745be) to head (21bcb63).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #493   +/-   ##
=======================================
  Coverage   76.82%   76.82%           
=======================================
  Files           5        5           
  Lines         164      164           
  Branches       60       59    -1     
=======================================
  Hits          126      126           
- Misses         35       38    +3     
+ Partials        3        0    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@duyet duyet merged commit 3e107b7 into main Apr 11, 2025
140 of 160 checks passed
@duyet duyet deleted the chore/ci-more-ch-versions branch April 11, 2025 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants