-
Notifications
You must be signed in to change notification settings - Fork 17
chore(ci): update test.yml to include CH versions 24.11, 24.12, 25.1, 25.2, and 25.3 #493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Reviewer's Guide by SourceryThis pull request updates the ClickHouse versions used in the No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @duyet - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider using a matrix strategy to avoid repeating the same configuration for different ClickHouse versions.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Review instructions: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Bundle ReportBundle size has no change ✅ Affected Assets, Files, and Routes:view changes for bundle: clickhouse-monitoring-bundle-client-array-pushAssets Changed:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #493 +/- ##
=======================================
Coverage 76.82% 76.82%
=======================================
Files 5 5
Lines 164 164
Branches 60 59 -1
=======================================
Hits 126 126
- Misses 35 38 +3
+ Partials 3 0 -3 ☔ View full report in Codecov by Sentry. |
Summary by Sourcery
CI: