feat(part-info): add part info page #491
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
Reviewer's Guide by SourceryThis pull request introduces a new 'Part Info' page that provides insights into table partitions and levels. It includes database and table selectors, displays partition and level counts in tables, and integrates with the existing menu and tables overview page. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @duyet - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a loading state for the database and table selectors in
app/[host]/part-info/layout.tsx. - The revalidate time is set to 300 seconds, but the query cache is enabled; consider if both are needed.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Review instructions: all looks good
- 🟢 Testing: all looks good
- 🟡 Complexity: 2 issues found
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Comment on lines
+23
to
+24
| const handleSelect = (newDatabase: string) => { | ||
| redirect(`/${host}/part-info/${newDatabase}`) |
There was a problem hiding this comment.
suggestion: Revisit use of redirect in a client component.
Since this component is marked with 'use client', consider using Next.js' useRouter hook and its push() method for client-side navigation instead of calling redirect from next/navigation, which is typically used in server components.
Suggested implementation:
+ import { useRouter } from 'next/navigation' const currentDatabase = params.database as string
const router = useRouter()
const handleSelect = (newDatabase: string) => {
router.push(`/${host}/part-info/${newDatabase}`)
}| @@ -0,0 +1,77 @@ | |||
| 'use client' | |||
There was a problem hiding this comment.
issue (complexity): Consider creating a custom hook to handle URL parameters to avoid code duplication in the DatabaseSelector and TableSelector components, which simplifies the filter logic by using a conditional check instead of a redundant one, and improves code maintainability and readability by centralizing the parameter extraction logic..
Consider abstracting URL parameter handling into a custom hook to eliminate duplication. For example, you could create:
// hooks/usePartInfoParams.ts
import { useParams } from 'next/navigation';
export function usePartInfoParams() {
const params = useParams();
return {
database: params.database as string,
table: params.table as string,
};
}Then update your selectors as follows:
// DatabaseSelector.tsx
import { redirect } from 'next/navigation';
import { Select, SelectContent, SelectItem, SelectTrigger, SelectValue } from '@/components/ui/select';
import { usePartInfoParams } from '@/hooks/usePartInfoParams';
export function DatabaseSelector({ host, databases }: { host: string; databases: string[] }) {
const { database: currentDatabase } = usePartInfoParams();
const handleSelect = (newDatabase: string) => {
redirect(`/${host}/part-info/${newDatabase}`);
};
return (
<Select value={currentDatabase} onValueChange={handleSelect}>
<SelectTrigger className="w-[180px]">
<SelectValue placeholder="Select Database" />
</SelectTrigger>
<SelectContent>
{databases.map((db) => (
<SelectItem key={db} value={db}>
{db}
</SelectItem>
))}
</SelectContent>
</Select>
);
}// TableSelector.tsx
import { redirect } from 'next/navigation';
import { Select, SelectContent, SelectItem, SelectTrigger, SelectValue } from '@/components/ui/select';
import { usePartInfoParams } from '@/hooks/usePartInfoParams';
export function TableSelector({ host, databaseTables }: { host: string; databaseTables: { database: string; table: string }[] }) {
const { database: currentDatabase, table: currentTable } = usePartInfoParams();
const handleSelect = (newTable: string) => {
redirect(`/${host}/part-info/${currentDatabase}/${newTable}`);
};
return (
<Select value={currentTable} onValueChange={handleSelect}>
<SelectTrigger className="w-[180px]">
<SelectValue placeholder="Select Table" />
</SelectTrigger>
<SelectContent>
{databaseTables
.filter((item) => currentDatabase ? item.database === currentDatabase : true)
.map((tbl) => (
<SelectItem key={tbl.table} value={tbl.table}>
{tbl.table}
</SelectItem>
))}
</SelectContent>
</Select>
);
}This approach reduces duplication and simplifies the filter logic by replacing the redundant check with a clear conditional.
| return tables?.[0] || '' | ||
| } | ||
|
|
||
| export const getDatabases = async (host: string): Promise<string[]> => { |
There was a problem hiding this comment.
issue (complexity): Consider using a Set to improve the efficiency and readability of the getDatabases function by simplifying the process of collecting unique database names.
Try replacing the `map` and `reduce` combination in `getDatabases` with a `Set` to simplify uniqueness handling. For example:
```ts
export const getDatabases = async (host: string): Promise<string[]> => {
const items = await getDatabaseTables(host)
return Array.from(new Set(items.map(item => item.database)))
}This change reduces complexity while keeping the functionality intact.
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #491 +/- ##
=======================================
Coverage 76.82% 76.82%
=======================================
Files 5 5
Lines 164 164
Branches 59 60 +1
=======================================
Hits 126 126
+ Misses 38 35 -3
- Partials 0 3 +3 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Add a new Part Info page to provide detailed information about active table parts and levels
New Features:
Enhancements: