Skip to content

Modularize os support #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 28, 2025
Merged

Modularize os support #152

merged 3 commits into from
Mar 28, 2025

Conversation

HDauven
Copy link
Member

@HDauven HDauven commented Mar 22, 2025

Resolves #151

Tested on a Nocturne Ubuntu node with archive feature enabled.

@HDauven
Copy link
Member Author

HDauven commented Mar 22, 2025

@wolfrage76 could you please give this a try too?

@wolfrage76
Copy link

I get:

Detected current user: wofl
Home directory: /home/wofl
Selected network: mainnet
Selected feature: default
Downloading installer package for additional scripts and configurations
Detected OS ID: linuxmint
Normalized OS target: ubuntu
No support script found for 'ubuntu'
Want to add support? See: https://github.com/dusk-network/node-installer#contributing-os-support

@HDauven
Copy link
Member Author

HDauven commented Mar 24, 2025

I get:

Detected current user: wofl Home directory: /home/wofl Selected network: mainnet Selected feature: default Downloading installer package for additional scripts and configurations Detected OS ID: linuxmint Normalized OS target: ubuntu No support script found for 'ubuntu' Want to add support? See: https://github.com/dusk-network/node-installer#contributing-os-support

Ah, my bad. That makes sense. The INSTALLER_URL is set to main, which doesn't contain the script yet.

If you pull the files locally, and adjust the INSTALLER_URL to https://github.com/dusk-network/node-installer/tarball/modularize-os-support, and run the node installer script locally, it should work.

@HDauven HDauven requested a review from d-sonuga March 25, 2025 12:05
@wolfrage76
Copy link

Sorry for the delay, tested and it worked once I updated the installer_url

@HDauven HDauven merged commit 85a3f79 into main Mar 28, 2025
@HDauven HDauven deleted the modularize-os-support branch March 28, 2025 09:30
@HDauven HDauven mentioned this pull request May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modularize OS support
4 participants