-
Notifications
You must be signed in to change notification settings - Fork 269
Disable FLoC #591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable FLoC #591
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now! Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Just one tiny fix, then we should be ready to ship.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 💥
Reviewer: @jonathanKingston
Tech Design: https://app.asana.com/0/481882893211075/1200159597529958/f
Description:
This disables FLoC API by opting all sites out of FLoC and removing the JS API.
Steps to test this PR:
clear browsing history
visit couple of websites
verify that document.interestCohort() doesn't return a cohort number (in context where we don't block the API - e.g. safelisted or any chrome:// page)
verify that document.interestCohort() is not available (in context where we block the API)
Make sure that:
Automated tests:
Reviewer Checklist:
PR Author Checklist: