Skip to content

Disable FLoC #591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 7, 2021
Merged

Disable FLoC #591

merged 5 commits into from
Apr 7, 2021

Conversation

kdzwinel
Copy link
Member

@kdzwinel kdzwinel commented Apr 7, 2021

Reviewer: @jonathanKingston
Tech Design: https://app.asana.com/0/481882893211075/1200159597529958/f

Description:

This disables FLoC API by opting all sites out of FLoC and removing the JS API.

Steps to test this PR:

  1. run chrome (89+) with flags that force FLoC on:
/Applications/Google\ Chrome\ Canary.app/Contents/MacOS/Google\ Chrome\ Canary --enable-blink-features=InterestCohortAPI --enable-features="FederatedLearningOfCohorts:update_interval/10s/minimum_history_domain_size_required/2,FlocIdSortingLshBasedComputation,InterestCohortFeaturePolicy"
  1. clear browsing history

  2. visit couple of websites

  3. verify that document.interestCohort() doesn't return a cohort number (in context where we don't block the API - e.g. safelisted or any chrome:// page)

  4. verify that document.interestCohort() is not available (in context where we block the API)

Make sure that:

Automated tests:

  • Unit tests
  • Integration tests
Reviewer Checklist:
  • Ensure the PR solves the problem
  • Review every line of code
  • Ensure the PR does no harm by testing the changes thoroughly
  • Get help if you're uncomfortable with any of the above!
  • Determine if there are any quick wins that improve the implementation
PR Author Checklist:
  • Get advice or leverage existing code
  • Agree on technical approach with reviewer (if the changes are nuanced)
  • Ensure that there is a testing strategy (and documented non-automated tests)
  • Ensure there is a documented monitoring strategy (if necessary)
  • Consider systems implications

@kdzwinel kdzwinel requested a review from dharb April 7, 2021 14:01
Copy link
Collaborator

@jonathanKingston jonathanKingston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now! Thanks

Copy link
Contributor

@dharb dharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Just one tiny fix, then we should be ready to ship.

Copy link
Contributor

@dharb dharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 💥

@dharb dharb merged commit 569a3a5 into develop Apr 7, 2021
@dharb dharb deleted the konrad/disable-floc branch April 7, 2021 21:01
@sammacbeth sammacbeth mentioned this pull request Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants