Skip to content

Multiple array elements on the same line #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 51 additions & 10 deletions src/expr.rs
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ use syn::{
ExprField, ExprForLoop, ExprGroup, ExprIf, ExprIndex, ExprInfer, ExprLet, ExprLit, ExprLoop,
ExprMacro, ExprMatch, ExprMethodCall, ExprParen, ExprPath, ExprRange, ExprRawAddr,
ExprReference, ExprRepeat, ExprReturn, ExprStruct, ExprTry, ExprTryBlock, ExprTuple, ExprUnary,
ExprUnsafe, ExprWhile, ExprYield, FieldValue, Index, Label, Member, PointerMutability,
ExprUnsafe, ExprWhile, ExprYield, FieldValue, Index, Label, Lit, Member, PointerMutability,
RangeLimits, ReturnType, Stmt, Token, UnOp,
};

Expand Down Expand Up @@ -167,16 +167,37 @@ impl Printer {

fn expr_array(&mut self, expr: &ExprArray) {
self.outer_attrs(&expr.attrs);
self.word("[");
self.cbox(INDENT);
self.zerobreak();
for element in expr.elems.iter().delimited() {
self.expr(&element, FixupContext::NONE);
self.trailing_comma(element.is_last);
if expr.elems.is_empty() {
self.word("[]");
} else if simple_array(&expr.elems) {
self.cbox(INDENT);
self.word("[");
self.zerobreak();
self.ibox(0);
for elem in expr.elems.iter().delimited() {
self.expr(&elem, FixupContext::NONE);
if !elem.is_last {
self.word(",");
self.space();
}
}
self.end();
self.trailing_comma(true);
self.offset(-INDENT);
self.word("]");
self.end();
} else {
self.word("[");
self.cbox(INDENT);
self.zerobreak();
for elem in expr.elems.iter().delimited() {
self.expr(&elem, FixupContext::NONE);
self.trailing_comma(elem.is_last);
}
self.offset(-INDENT);
self.end();
self.word("]");
}
self.offset(-INDENT);
self.end();
self.word("]");
}

fn expr_assign(&mut self, expr: &ExprAssign, fixup: FixupContext) {
Expand Down Expand Up @@ -1378,6 +1399,26 @@ pub fn simple_block(expr: &Expr) -> Option<&ExprBlock> {
None
}

pub fn simple_array(elements: &Punctuated<Expr, Token![,]>) -> bool {
for expr in elements {
if let Expr::Lit(expr) = expr {
match expr.lit {
#![cfg_attr(all(test, exhaustive), deny(non_exhaustive_omitted_patterns))]
Lit::Byte(_) | Lit::Char(_) | Lit::Int(_) | Lit::Bool(_) => {}

Lit::Str(_) | Lit::ByteStr(_) | Lit::CStr(_) | Lit::Float(_) | Lit::Verbatim(_) => {
return false;
}

_ => return false,
}
} else {
return false;
}
}
true
}

// Expressions for which `$expr` and `{ $expr }` mean the same thing.
//
// This is not the case for all expressions. For example `{} | x | x` has some
Expand Down
40 changes: 31 additions & 9 deletions src/mac.rs
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,7 @@ fn is_keyword(ident: &Ident) -> bool {
#[cfg(feature = "verbatim")]
mod standard_library {
use crate::algorithm::Printer;
use crate::expr;
use crate::fixup::FixupContext;
use crate::iter::IterDelimited;
use crate::path::PathKind;
Expand Down Expand Up @@ -618,16 +619,37 @@ mod standard_library {
semicolon = false;
}
KnownMacro::VecArray(vec) => {
self.word("[");
self.cbox(INDENT);
self.zerobreak();
for elem in vec.iter().delimited() {
self.expr(&elem, FixupContext::NONE);
self.trailing_comma(elem.is_last);
if vec.is_empty() {
self.word("[]");
} else if expr::simple_array(vec) {
self.cbox(INDENT);
self.word("[");
self.zerobreak();
self.ibox(0);
for elem in vec.iter().delimited() {
self.expr(&elem, FixupContext::NONE);
if !elem.is_last {
self.word(",");
self.space();
}
}
self.end();
self.trailing_comma(true);
self.offset(-INDENT);
self.word("]");
self.end();
} else {
self.word("[");
self.cbox(INDENT);
self.zerobreak();
for elem in vec.iter().delimited() {
self.expr(&elem, FixupContext::NONE);
self.trailing_comma(elem.is_last);
}
self.offset(-INDENT);
self.end();
self.word("]");
}
self.offset(-INDENT);
self.end();
self.word("]");
}
KnownMacro::VecRepeat { elem, n } => {
self.word("[");
Expand Down