Skip to content

Add fleets property to run configurations and CLI #2488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 9, 2025
Merged

Conversation

un-def
Copy link
Collaborator

@un-def un-def commented Apr 8, 2025

Closes: #1447

@peterschmidt85
Copy link
Contributor

@un-def The property in the run configuration YAML file (and API) should be fleets and must accept an array. Is it implemented this way? Just want to confirm.

@un-def
Copy link
Collaborator Author

un-def commented Apr 8, 2025

@peterschmidt85 it accepts both a name and a list of names. I chose the singular form because I think it will be mostly used with a single fleet

@un-def un-def requested a review from r4victor April 8, 2025 15:59
@peterschmidt85
Copy link
Contributor

@peterschmidt85 it accepts both a name and a list of names. I chose the singular form because I think it will be mostly used with a single fleet

I strongly suggest to use plural - similar to regions and backends and always require a list.

@un-def un-def changed the title Add fleet property to run configurations and CLI Add fleets property to run configurations and CLI Apr 9, 2025
@un-def un-def merged commit 3b02bc4 into master Apr 9, 2025
24 checks passed
@un-def un-def deleted the 1447_run_conf_fleet branch April 9, 2025 09:53
Bihan pushed a commit to Bihan/dstack that referenced this pull request Apr 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to pass --fleet NAME to dstack run (and also specify from YAML)
3 participants