Skip to content

Added support for parameter CachingMode #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 30, 2019
Merged

Added support for parameter CachingMode #29

merged 5 commits into from
Mar 30, 2019

Conversation

johlju
Copy link
Member

@johlju johlju commented Mar 30, 2019

Pull Request (PR) description

This PR continues the work that @MartinVokurek started in PR #11. All credit goes to Martin!

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry under the Unreleased section of the change log in the README.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is Reviewable

MartinVokurek and others added 5 commits March 30, 2019 07:21
Adds CachingMode parameter to the Test and Get functions and defines
possible values (matches Set-SmbShare). Fixes #8
Improved Code quality, cosmetic, & Added the ability to have all Access variables present, but allow for null or empty.
@johlju johlju changed the title Changes from pr#11 Added support for parameter CachingMode Mar 30, 2019
@codecov-io
Copy link

codecov-io commented Mar 30, 2019

Codecov Report

Merging #29 into dev will increase coverage by 0.14%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev      #29      +/-   ##
==========================================
+ Coverage   79.71%   79.85%   +0.14%     
==========================================
  Files           1        1              
  Lines         138      139       +1     
  Branches        1        1              
==========================================
+ Hits          110      111       +1     
  Misses         27       27              
  Partials        1        1
Impacted Files Coverage Δ
DscResources/MSFT_xSmbShare/MSFT_xSmbShare.psm1 79.85% <100%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c74df4...8dc6680. Read the comment docs.

Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 2 files at r1, 1 of 1 files at r2, 1 of 1 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@johlju johlju merged commit c589b81 into dsccommunity:dev Mar 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Caching Settings (Offline Settings)
3 participants