-
Notifications
You must be signed in to change notification settings - Fork 150
xWebSite: skip certificate thumbprint and store name check when SslFlags are valid #600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, 3 unresolved discussions (waiting on @changbowen and @johlju)
a discussion (no related file):
Please add a unit test for this change: https://github.com/dsccommunity/xWebAdministration/blob/673d20f7a73d2e6bfdd0715a5628bd7ffa708d5f/tests/Unit/MSFT_xWebsite.Tests.ps1#L2273
a discussion (no related file):
Please update the CHANGELOG.md with an entry for this change.
source/DSCResources/MSFT_xWebSite/MSFT_xWebSite.psm1, line 1439 at r1 (raw file):
{ if ([Environment]::OSVersion.Version -lt '6.2' -or $binding.SslFlags -notin @('2', '3')) {
We should indent the code inside the brace.
Indent added. |
Yes to both. You should add a unit test that verifies that the new code path works, and if existing tests fail then either the code change must be revised or existing unit tests revised. The CHANGELOG.md is used as the release notes for the next release. By adding a new entry under the Unreleased-section it will be automatically used in the release notes. |
We have renamed the resource, removeing 'x', so please rebase this PR. |
Works if you use: |
The resource xWebSite has been renamed. |
Pull Request (PR) description
SslFlags value 2 and 3 suggest the use of CCS (Central Certificate Store). Checking for certificate thumbprint and store name should be skipped when CCS is being used.
In IIS Management Console the SSL certificate field would be disabled when CCS is enabled.
This Pull Request (PR) fixes the following issues
Fixes #199
Task list
file CHANGELOG.md. Entry should say what was changed and how that
affects users (if applicable), and reference the issue being resolved
(if applicable).
and comment-based help.
This change is