Skip to content

Restart-SqlService: Correctly evaluate timeout value #1890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 28, 2023

Conversation

johlju
Copy link
Member

@johlju johlju commented Mar 28, 2023

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation updated in the resource's README.md.
  • Resource parameter descriptions updated in schema.mof.
  • Comment-based help updated, including parameter descriptions.
  • Localization strings updated.
  • Examples updated.
  • Unit tests updated. See DSC Community Testing Guidelines.
  • Integration tests updated (where possible). See DSC Community Testing Guidelines.
  • Code changes adheres to DSC Community Style Guidelines.

This change is Reviewable

@johlju
Copy link
Member Author

johlju commented Mar 28, 2023

Can't add a unit tests for this change since the that would mean to run a test for more than 60 seconds which hold up CI for over a minute. To be able to unit test means a more substantial change than the bug necessitate.

@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Merging #1890 (196010e) into main (c780423) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff          @@
##           main   #1890   +/-   ##
====================================
  Coverage    92%     92%           
====================================
  Files        85      85           
  Lines      7640    7640           
====================================
  Hits       7038    7038           
  Misses      602     602           
Flag Coverage Δ
unit 92% <ø> (ø)
Impacted Files Coverage Δ
...dules/SqlServerDsc.Common/SqlServerDsc.Common.psm1 98% <ø> (ø)

@johlju johlju added the needs review The pull request needs a code review. label Mar 28, 2023
Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johlju)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restart-SqlService: Evaluates wrong property for total seconds
1 participant