Skip to content

ExchEcpVirtualDirectory and ExchOwaVirtualDirectory: add OAuthAuthentication property #504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

MrBookie7
Copy link

@MrBookie7 MrBookie7 commented Mar 18, 2025

Pull Request (PR) description

  • ExchEcpVirtualDirectory
    • Added parameter OAuthAuthentication
  • ExchOwaVirtualDirectory
    • Added parameter OAuthAuthentication

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the file CHANGELOG.md.
    Entry should say what was changed and how that affects users (if applicable), and
    reference the issue being resolved (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof and comment-based
    help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

Copy link

codecov bot commented Mar 19, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 52%. Comparing base (1d15ce4) to head (37951bb).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...aVirtualDirectory/DSC_ExchOwaVirtualDirectory.psm1 33% 2 Missing ⚠️

❌ Your project check has failed because the head coverage (52%) is below the target coverage (70%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@         Coverage Diff         @@
##           main   #504   +/-   ##
===================================
  Coverage    52%    52%           
===================================
  Files        44     44           
  Lines      5739   5745    +6     
===================================
+ Hits       2996   3000    +4     
- Misses     2743   2745    +2     
Files with missing lines Coverage Δ
...pVirtualDirectory/DSC_ExchEcpVirtualDirectory.psm1 97% <100%> (ø)
...aVirtualDirectory/DSC_ExchOwaVirtualDirectory.psm1 32% <33%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MrBookie7
Copy link
Author

@johlju could you please review and advise? I'm unsure if I need to do anything about the failed codedov/project check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ExchEcpVirtualDirectory and ExchOwaVirtualDirectory: missing OAuthAuthentication property
1 participant