Skip to content

DnsServerDsc: Consider renaming the module #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
johlju opened this issue Feb 15, 2021 · 4 comments · Fixed by #241
Closed

DnsServerDsc: Consider renaming the module #179

johlju opened this issue Feb 15, 2021 · 4 comments · Fixed by #241
Labels
breaking change When used on an issue, the issue has been determined to be a breaking change. in progress The issue is being actively worked on by someone.
Milestone

Comments

@johlju
Copy link
Member

johlju commented Feb 15, 2021

Suggest we consider renaming the module from xDnsServer to DnsServerDsc since 'x' no longer have any meaning. This is inline with the other modules that have been renamed. This should also remove the 'x' from all the resource names.

@johlju johlju added the breaking change When used on an issue, the issue has been determined to be a breaking change. label Feb 15, 2021
@johlju
Copy link
Member Author

johlju commented Feb 15, 2021

At the same time we should change the resource prefixes from MSFT to DSC to indicate that it is the DSC Community that maintains the resources.

@gaelcolas
Copy link
Member

I think it'd be great to do that when the current PRs are merged and released to PSGallery.
We could release 2.0.0 (after all pre-releases are out), and then upgrade the repo (rename, and make the code change, and the Pipeline change).
Then we could release DnsServerDsc as v2.1.0 and unlist the old xDnsServer from the gallery (invisible but still accessible if you install specific/pinned version.

I'd be happy to give a hand, @Sudman1, @indented-automation, @johlju we'd just need to sync our efforts.

@indented-automation
Copy link
Contributor

indented-automation commented Feb 17, 2021 via email

@johlju
Copy link
Member Author

johlju commented Mar 25, 2021

DnsServerDsc will be release as 3.0.0 as it will be breaking change with new module name and also there will be breaking changes that we don't add to the 2.0.0 release.

@johlju johlju added the in progress The issue is being actively worked on by someone. label Mar 26, 2021
johlju added a commit that referenced this issue Mar 27, 2021
- DnsServerDsc
  - BREAKING CHANGE: Renamed the module to DnsServerDsc (issue #179).
johlju added a commit that referenced this issue Mar 27, 2021
- DnsServerDsc
  - BREAKING CHANGE: Removed the prefix 'x' from all MOF-based resources (issue #179).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change When used on an issue, the issue has been determined to be a breaking change. in progress The issue is being actively worked on by someone.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants