Skip to content

Convert nested modules to buildable modules #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Migrate unit tests to Pester 5
- IPv6 preparation work
- Increased code coverage to >85% fixes [#60](https://github.com/dsccommunity/DhcpServerDsc/issues/60).
- `DhcpServerDsc.Common`
- Convert to buildable module with per file functions.
- `DhcpServerDsc.OptionValueHelper`
- Convert to buildable module with per file functions.

### Added

Expand Down
27 changes: 21 additions & 6 deletions build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
CopyPaths:
- en-US
- DSCResources
- Modules
Encoding: UTF8
VersionedOutputDirectory: true
BuiltModuleSubdirectory: builtModule
Expand All @@ -16,11 +15,27 @@ BuiltModuleSubdirectory: builtModule
####################################################

NestedModule:
DscResource.Common:
CopyOnly: true
Path: ./output/RequiredModules/DscResource.Common
AddToManifest: false
Exclude: PSGetModuleInfo.xml
DscResource.Common:
CopyOnly: true
Path: ./output/RequiredModules/DscResource.Common
AddToManifest: false
Exclude: PSGetModuleInfo.xml
DhcpServerDsc.Common:
Prefix: prefix.ps1
VersionedOutputDirectory: false
CopyPaths:
- en-US
Encoding: UTF8
AddToManifest: false
Exclude: PSGetModuleInfo.xml
DhcpServerDsc.OptionValueHelper:
Prefix: prefix.ps1
VersionedOutputDirectory: false
CopyPaths:
- en-US
Encoding: UTF8
AddToManifest: false
Exclude: PSGetModuleInfo.xml

####################################################
# Pipeline Configuration #
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,7 @@
Description = 'Common functions used by the DSC resources in DhcpServerDsc.'

# Functions to export from this module, for best performance, do not use wildcards and do not delete the entry, use an empty array if there are no functions to export.
FunctionsToExport = @(
'New-TerminatingError'
'Get-ValidIPAddress'
'Assert-ScopeParameter'
'Write-PropertyMessage'
'Get-ValidTimeSpan'
)
FunctionsToExport = @()

# Cmdlets to export from this module, for best performance, do not use wildcards and do not delete the entry, use an empty array if there are no cmdlets to export.
CmdletsToExport = @()
Expand Down
249 changes: 0 additions & 249 deletions source/Modules/DhcpServerDsc.Common/DhcpServerDsc.Common.psm1

This file was deleted.

Loading