Skip to content

Resource DhcpServerDnsDynamicUpdates #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

dan-hughes
Copy link
Contributor

@dan-hughes dan-hughes commented Feb 11, 2025

Pull Request (PR) description

Add resources:

  • DhcpServerv4DnsDynamicUpdates
  • DhcpServerv6DnsDynamicUpdates

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the file CHANGELOG.md.
    Entry should say what was changed and how that affects users (if applicable), and
    reference the issue being resolved (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof and comment-based
    help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

@dan-hughes
Copy link
Contributor Author

Blocked by #94

@dan-hughes
Copy link
Contributor Author

@johlju, thought's on IPv4 and IPv6 functionality being in the same module?
It's a lot less complex in this case to separate them as both don't use the same parameters.

@johlju
Copy link
Member

johlju commented Feb 14, 2025

Can we move those parameters that are equal to a parent class? Similar to SqlResourceBase but maybe call it something like DhcpServerDnsDynamicUpdatesBase unless the parameters can be used for even more resources then maybe a more generic name, but might be hard to know now 🤔

Also, is it possible to use an enum as datatype for a key property? I did not know that.

@johlju
Copy link
Member

johlju commented Feb 15, 2025

thought's on IPv4 and IPv6 functionality being in the same module?

Didn't answer your actual question. 🙂 Assuming you mean same resource. I have no issue with them being separated as long as the properties of one cannot be enforced by the other. If they can then there could be a "ping-pong" behavior if they were to be in the same configuration with different values. Then I would recommend them to be in the same resource 🤔

@dan-hughes
Copy link
Contributor Author

Correct, I did mean resource.

I think this case it's easier to keep separate, I may look at a base class though as it will reduce some duplication.

@dan-hughes dan-hughes changed the title Resource DhcpSserverDnsDynamicUpdates Resource DhcpServerDnsDynamicUpdates Feb 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configure DHCP Server DNS Dynamic Updates
2 participants