-
Notifications
You must be signed in to change notification settings - Fork 34
Resource DhcpServerDnsDynamicUpdates #95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Resource DhcpServerDnsDynamicUpdates #95
Conversation
Blocked by #94 |
@johlju, thought's on IPv4 and IPv6 functionality being in the same module? |
Can we move those parameters that are equal to a parent class? Similar to SqlResourceBase but maybe call it something like Also, is it possible to use an enum as datatype for a key property? I did not know that. |
Didn't answer your actual question. 🙂 Assuming you mean same resource. I have no issue with them being separated as long as the properties of one cannot be enforced by the other. If they can then there could be a "ping-pong" behavior if they were to be in the same configuration with different values. Then I would recommend them to be in the same resource 🤔 |
Correct, I did mean resource. I think this case it's easier to keep separate, I may look at a base class though as it will reduce some duplication. |
Pull Request (PR) description
Add resources:
DhcpServerv4DnsDynamicUpdates
DhcpServerv6DnsDynamicUpdates
This Pull Request (PR) fixes the following issues
Task list
Entry should say what was changed and how that affects users (if applicable), and
reference the issue being resolved (if applicable).
help.
This change is