-
Notifications
You must be signed in to change notification settings - Fork 19
BREAKING CHANGE: MSFT_DFSNamespaceRoot/MSFT_DFSNamespaceFolder: DFSNamespace Support for ReferralStatus (State) Modification #97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
BREAKING CHANGE: - Add support for setting a DFS Namespace root target's referral status (state) to be either Online or Offline in MSFT_DFSNamespaceRoot. State is now a required parameter. - Add support for setting a DFS Namespace folder target's referral status (state) to be either Online or Offline in MSFT_DFSNamespaceFolder. State is now a required parameter. - Update examples to support new required parameter.
Codecov Report
@@ Coverage Diff @@
## dev #97 +/- ##
====================================
- Coverage 95% 59% -36%
====================================
Files 8 8
Lines 1071 1095 +24
====================================
- Hits 1021 650 -371
- Misses 50 445 +395 |
Hi, |
Hi, I did not spot this PR before, but it looks like it'd need some tests setup unless I'm not reading the codcov report rights. I'm happy to review and merge if and when the test passes if Dan is busy, or to assist if someone need help. @heimdallreport feel free to fork his branch and continue the work in a new PR, or ask @thesmall if you can help getting this PR to pass the tests. |
Hey all. @gaelcolas you're correct in the assessment that there are no tests present. Truth of the matter is that, while I can write the code to actually make the DSC Resource work, I have almost no idea how to write the appropriate and necessary tests. If someone would be willing to work with me on getting the tests written, I would be grateful and would be happy to further facilitate getting this branch merged. |
Thanks @Borgquite - closing as addressed in #126. |
Pull Request (PR) description
BREAKING CHANGE:
in MSFT_DFSNamespaceRoot. State is now a required parameter.
in MSFT_DFSNamespaceFolder. State is now a required parameter.
This Pull Request (PR) fixes the following issues
This pull request does not fix any issues.
Task list
Entry should say what was changed, and how that affects users (if applicable).
and comment-based help.
This change is