Skip to content

BREAKING CHANGE: MSFT_DFSNamespaceRoot/MSFT_DFSNamespaceFolder: DFSNamespace Support for ReferralStatus (State) Modification #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

thesmall
Copy link

@thesmall thesmall commented Jan 20, 2020

Pull Request (PR) description

BREAKING CHANGE:

  • Add support for setting a DFS Namespace root target's referral status (state) to be either Online or Offline
    in MSFT_DFSNamespaceRoot. State is now a required parameter.
  • Add support for setting a DFS Namespace folder target's referral status (state) to be either Online or Offline
    in MSFT_DFSNamespaceFolder. State is now a required parameter.
  • Update examples to support new required parameter.

This Pull Request (PR) fixes the following issues

This pull request does not fix any issues.

Task list

  • Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in README.md in the resource folder.
  • Resource parameter descriptions added/updated in schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is Reviewable

Ben Small added 2 commits January 20, 2020 09:14
BREAKING CHANGE:
 - Add support for setting a DFS Namespace root target's referral status (state) to be either Online or Offline
   in MSFT_DFSNamespaceRoot. State is now a required parameter.
 - Add support for setting a DFS Namespace folder target's referral status (state) to be either Online or Offline
   in MSFT_DFSNamespaceFolder. State is now a required parameter.
 - Update examples to support new required parameter.
@codecov
Copy link

codecov bot commented Jan 20, 2020

Codecov Report

Merging #97 into dev will decrease coverage by 35%.
The diff coverage is 0%.

Impacted file tree graph

@@         Coverage Diff          @@
##            dev    #97    +/-   ##
====================================
- Coverage    95%    59%   -36%     
====================================
  Files         8      8            
  Lines      1071   1095    +24     
====================================
- Hits       1021    650   -371     
- Misses       50    445   +395

@mfagotto
Copy link

Hi,
is there any plan make this feature available in future releases?

@gaelcolas
Copy link
Member

Hi, I did not spot this PR before, but it looks like it'd need some tests setup unless I'm not reading the codcov report rights.
I know @PlagueHO is busy these days so he won't be able to make this PR work soon if it does not pass the tests.

I'm happy to review and merge if and when the test passes if Dan is busy, or to assist if someone need help.

@heimdallreport feel free to fork his branch and continue the work in a new PR, or ask @thesmall if you can help getting this PR to pass the tests.

@thesmall
Copy link
Author

Hey all. @gaelcolas you're correct in the assessment that there are no tests present. Truth of the matter is that, while I can write the code to actually make the DSC Resource work, I have almost no idea how to write the appropriate and necessary tests.

If someone would be willing to work with me on getting the tests written, I would be grateful and would be happy to further facilitate getting this branch merged.

@PlagueHO
Copy link
Member

Hi @heimdallreport - not sure how I missed this. And apologies to @thesmall. I suspect it was during the transition to the new CI pipelines.

I'd love to get this through, so if you're still working on this @thesmall, keen to get the conflicts resolved.

@Borgquite
Copy link
Contributor

@PlagueHO FYI This merge can be discarded since it was included in #126

@PlagueHO
Copy link
Member

PlagueHO commented Aug 4, 2023

Thanks @Borgquite - closing as addressed in #126.

@PlagueHO PlagueHO closed this Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review The pull request needs a code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants