Skip to content

Adds new resource DismFeature #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

johlju
Copy link
Member

@johlju johlju commented Mar 21, 2020

Pull Request (PR) description

  • ComputerManagementDsc
    • Added new resource DismFeature.

Deprecates the xDismFeature resource in the module xDismFeature. Suggest doing this instead of maintain a single resource module.

This Pull Request (PR) fixes the following issues

Partly issue PowerShell/DscResources#374

Task list

  • Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in README.md in resource folder.
  • Resource parameter descriptions added/updated in schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is Reviewable

@johlju johlju added the needs review The pull request needs a code review. label Mar 21, 2020
@johlju johlju requested a review from PlagueHO March 21, 2020 16:50
@johlju
Copy link
Member Author

johlju commented Mar 24, 2020

@PlagueHO let’s wait with this one as it seems this is no longer necessary. If there haven’t been any reported scenarios by this upcoming weekend where this resource is necessary then I close this and just deprecate the xDismFeature repo. If there are scenarios for this in the future I will be keeping the working branch.

@PlagueHO
Copy link
Member

@johlju - you might be right. What was the difference between using DISM and *-WindowsFeature? It seems like they cover the same area....

@johlju
Copy link
Member Author

johlju commented Mar 26, 2020

I’m not sure as I never have used DISM to install anything as far as I can remember. I sent a tweet and asked in #DSC channel but haven’t yet seen a scenario where it is needed.
Maybe this pre-WindowsFeature (older OS:es that is no longer supported)

@PlagueHO
Copy link
Member

Cool. Maybe a resource we could drop. I suspect it was for Windows Server 2008 R2 that didn't have the *-WindowsFeature cmdlets....

@johlju
Copy link
Member Author

johlju commented Mar 28, 2020

Closing this PR. There has not been any reported workloads that need this resource. If a resource for DISM is ever needed then I will keep the working branch, and the code will still exist in the closed PR for reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants