Skip to content

feat: [CI-17122]: ECR auth for push-only operation + code refactoring #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2025
Merged

feat: [CI-17122]: ECR auth for push-only operation + code refactoring #144

merged 1 commit into from
Apr 25, 2025

Conversation

Ompragash
Copy link
Member

@Ompragash Ompragash commented Apr 16, 2025 •
edited
Loading

Fixed an issue with the push-only operation where ECR credentials were being incorrectly used, causing "invalid security token" errors.

Changes:

  • Modified setDockerAuth to return ECR credentials for reuse in Crane operations
  • Eliminated redundant authentication code in handlePushOnly
  • Improved error handling for all authentication flows
  • Added better comments to clarify different auth code paths

Testing: LINK

@Ompragash Ompragash marked this pull request as ready for review April 24, 2025 09:53
@Ompragash Ompragash merged commit a091f2a into main Apr 25, 2025
2 of 3 checks passed
@hemanthmantri
Copy link
Contributor

Please add UTs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DevanshMathur19 DevanshMathur19 DevanshMathur19 approved these changes

@anurag-harness anurag-harness Awaiting requested review from anurag-harness

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ompragash @hemanthmantri @DevanshMathur19