sqlite: Fix duplicate index statements in upgrade #4708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fall through case in logSuggestionsAndReturn simply appended whatever was received to the existing list. This in turn lead to duplicate index creation steps as seen in issue drizzle-team#3574. Verify a statement does not already exist before appending to the list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fall through case in logSuggestionsAndReturn simply appended whatever was received to the existing list. This in turn lead to duplicate index creation steps as seen in issue #3574.
In the upgrade scenario, the call to _moveDataStatements would create the statements to create the indexes on the new table. Then the foreach would turn right around and add more create index statements. This is resulted in broken upgrade experience b/c upgrade would attempt to create 2x indexes as needed.
The fix verifies a statement does not already exist before appending to the statement list.