Skip to content

Make DDF manufacturer name matching case insensitive #7864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

manup
Copy link
Member

@manup manup commented Jul 30, 2024

This fixes a regression from v2.27.0-beta. A DDF should match a manufacturer name regardless if it is given as "HEIMAN", "Heiman", "heiman", etc.

Note this applies only to plain ASCII strings. For manufacturer names which contain multi-byte UTF-8 characters the DDF must have the exact name representation. This should by fine for 99% of all cases.

This fixes a regression from v2.27.0-beta.
A DDF should match regardless if the manufacturer name is given as "HEIMAN", "Heiman", "heiman", etc.

Note this applies only to plain ASCII strings. For manufacturer names which contain multibyte UTF-8 characters the DDF must have the exact name representation. This should by fine for 99% of all cases.
@manup manup added the Fix label Jul 30, 2024
@manup manup added this to the v2.28.0-beta milestone Jul 30, 2024
@manup manup mentioned this pull request Jul 30, 2024
@manup manup merged commit 82df115 into dresden-elektronik:master Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant