IKEA STYRBAR and Minor changes

[ebaauw]

• Add support for IKEA STYRBAR, see Device Request IKEA STYRBAR #4572.
  • Whitelist device in de_web_plugin.cpp;
  • Add commands to button_map.json;
  • Hack in checkSensorButtonEvent() to ignore additional commands on holding left or right button (see issue);
  • Streamline code for SHORTCUT and SYMFONISK, in line with STYRBAR:
    • Only bind OnOff client cluster to group;
    • Discard unicast from client cluster to prevent double button events;
    • Fix bugs in verifying bindings/reporting;
    • Remove unneeded code for binding SYMFONISK to coordinator, as it sends commands to coordinator already by default.
  • TODO: Check older IKEA end devices for double button events (haven't seen any reports, so don't expect any;
  • TODO: Check whether old wireless dimmer (with dial) sends commands to coordinator by default as well;
  • TODO: Check whether old IKEA end devices can do with one client binding as well.
• Add support for Aqara Opple in controller mode, see No switch event x003 after long press - Aqara/Opple  #4589. No support for switching modes, though; you'll need to do this manually through the GUI (as describes in the issue)... every time deCONZ restarts;
  • Add commands to button_map.json;
  • Add support for Step Color Temperature command in checkSensorButtonEvent();
• Add to general.xml the IKEA-specific scene commands as sent by the TRADFRI remote control on the left and right buttons, so they can be sent from the GUI. Still cannot get them to work, though...
• Add new button mapping for TRADFRI wireless dimmer, under mode 1, see Wiki.
• Disable check for "too fast event", as this interferes with the correct function of several IKEA and Hue devices.

[manup]

Ah damn I pressed "Ready for review" thinking I was starting review but now PR status changed.
So far PR looks fine to me.

[manup]

Looks fine so far

[ebaauw]

I think this is good to go for now. Still sanity-checking the older IKEA controllers (see also new [Wiki](https://github.com/dresden-elektronik/deconz-rest-plugin/wiki/IKEA-controllers page).

@manup, @SwoopX please note that I commented out the check for "too fast event": it's perfectly legal for IKEA and Hue devices to send more events within 0.5s. The check causes mismatches in x000/x001/x003 sequences. I think we need to whitelist the devices for which this check is needed, if at all. The double events for IKEA are all due to the device sending the command twice, once by groupcast and once by unicast; as a remedy, I simply ignore the unicast.

[manup]

@manup, @SwoopX please note that I commented out the check for "too fast event": it's perfectly legal for IKEA and Hue devices to send more events within 0.5s. The check causes mismatches in x000/x001/x003 sequences. I think we need to whitelist the devices for which this check is needed, if at all. The double events for IKEA are all due to the device sending the command twice, once by groupcast and once by unicast; as a remedy, I simply ignore the unicast.

This was introduced in v2.5.33 in 2018 0f89afe due problems with Busch Jaeger switches 0ed3d17 So it might be that these are the only ones (or perhaps it isn't needed at all anymore).

[ebaauw]

I commented out the check for "too fast event"

This was introduced in v2.5.33 in 2018 0f89afe due problems with Busch Jaeger switches 0ed3d17 So it might be that these are the only ones (or perhaps it isn't needed at all anymore).

If it's no longer needed, let's please remove it. If still needed, can we whitelist Busch Jaeger on manufacturer code or manufacturer name, or do we need each model identifier? Alternatively, I could blacklist manufacturer codes for Philips and IKEA. Not sure if there's other devices that have come to rely on this check.

[manup]

If it's no longer needed, let's please remove it. If still needed, can we whitelist Busch Jaeger on manufacturer code or manufacturer name, or do we need each model identifier? Alternatively, I could blacklist manufacturer codes for Philips and IKEA. Not sure if there's other devices that have come to rely on this check.

That's a good question I can't test the BJ switch currently. Would like to remove this code as well, but I guess the safest bet is to disable it for IKEA and Philips since these are the ones we can be certain?

[ebaauw]

the safest bet is to disable it for IKEA and Philips since these are the ones we can be certain?

Done.