Improve Samjin multi sensor and Samjin battery reporting #4186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The device has 3 resources, configuring the cluster for one is enough.
Same configuration as SmartThings uses.
Align to specification
… cluster For ZCL data type bitmap there is no reportable change field.
Since the IAS Zone Status reporting is not needed for main operation functionality and is more used as an is_alive ping, it shouldn't drain the battery too much.
Typo in condition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Align with original SmartThings configuration
Issue: #4131
The main battery safer comes via Poll Control configuration PR: #4163 formerly SmartThings devices did MAC Data Polling in very short intervals, sometimes every 5–10 seconds. With the PR this interval is raised to 15 minutes.