Skip to content

Require setuptools >= 75.1.0 #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2025
Merged

Require setuptools >= 75.1.0 #49

merged 1 commit into from
Apr 24, 2025

Conversation

cninowize
Copy link
Collaborator

Adds a minimum version requirement for the setuptools package to ensure compatibility and access to necessary features or fixes.

Adds a minimum version requirement for the setuptools package to ensure compatibility and access to necessary features or fixes.
Copy link
Collaborator

@olveraa olveraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please explain in this PR what kind of compatibility do you mean, and why it is important @cninowize ?

@AlanKev117
Copy link
Collaborator

I remember having an error installing the library with pip, which I think has something to do with the missing setuptools package.

@cninowize
Copy link
Collaborator Author

Could you please explain in this PR what kind of compatibility do you mean, and why it is important @cninowize ?

Its to avoid problems when we use a new docker image. Working with Docker, usually we use as a starting point a minimum Python image and then installing a set of packages. In this case, what' s missing is a reference to the setuptools package within the setup.py

@olveraa
Copy link
Collaborator

olveraa commented Apr 23, 2025

Thanks @cninowize just if we come back to the future here, to have a bit of context. I let my approve and well all comments given in the description of the PR would be helpful.

@cninowize cninowize merged commit b1ecd1c into master Apr 24, 2025
@cninowize cninowize deleted the feature/DNASNS-2982 branch April 24, 2025 15:45
@cninowize cninowize restored the feature/DNASNS-2982 branch April 28, 2025 14:49
@cninowize cninowize deleted the feature/DNASNS-2982 branch April 28, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants