Skip to content

Correctly reference ref project for Windows.Primitives.csproj #10122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Nov 26, 2024

Fixes dotnet/source-build#4761

When building windowsdesktop inside the VMR for win-x86, the System.Windows.Primitives reference assembly is missing. This PR corrects the issue by adding a ProjectReference to the System.Windows.Primitives-ref.csproj file. All other projects have that so it was probably just missed.

Fixes the following error:

D:\a_work\1\s\artifacts\source-built-sdks\Microsoft.DotNet.SharedFramework.Sdk\targets\sharedfx.targets(418,5): error : Classification matches no files: System.Windows.Primitives.dll [D:\a_work\1\s\src\windowsdesktop\src\windowsdesktop\src\sfx\Microsoft.WindowsDesktop.App.Ref.sfxproj]

@ViktorHofer ViktorHofer requested review from a team as code owners November 26, 2024 23:09
@dotnet-policy-service dotnet-policy-service bot added the PR metadata: Label to tag PRs, to facilitate with triage label Nov 26, 2024
@ViktorHofer ViktorHofer marked this pull request as draft November 26, 2024 23:13
@ViktorHofer ViktorHofer marked this pull request as ready for review November 27, 2024 07:52
@ViktorHofer
Copy link
Member Author

@dotnet/wpf-developers please take a look

@ViktorHofer
Copy link
Member Author

gentle ping @dotnet/wpf-developers

@JeremyKuhne
Copy link
Member

Thanks @ViktorHofer!

(Virtual Monolithic Repository (VMR))

@dipeshmsft dipeshmsft merged commit 227c5cf into main Dec 2, 2024
8 checks passed
@dipeshmsft dipeshmsft deleted the ViktorHofer-patch-1 branch December 2, 2024 12:38
@github-actions github-actions bot locked and limited conversation to collaborators Jan 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VMR win-x86 builds are broken because of a windowsdesktop failure
3 participants