This repository was archived by the owner on Nov 20, 2023. It is now read-only.
process needs to be disposed of #252
Merged
+10
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonCropp
requested review from
davidfowl,
jkotalik and
rynowak
as code owners
davidfowl
reviewed
Mar 30, 2020
| @@ -347,6 +347,12 @@ private void WriteReplicaToStore(string pid) | |||
| return null; | |||
| } | |||
|
|
|||
| private static string GetEntryPointFilePath() | |||
| { | |||
| using var process = Process.GetCurrentProcess(); | |||
There was a problem hiding this comment.
Does this return a new instance every time?
There was a problem hiding this comment.
yep
public static Process GetCurrentProcess()
{
return new Process(".", isRemoteMachine: false, NativeMethods.GetCurrentProcessId(), null);
}
There was a problem hiding this comment.
i think "returns new instance" is meant to be implied by the fact that it is a method and not a property
davidfowl
approved these changes
Mar 30, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.