Skip to content
This repository was archived by the owner on Nov 20, 2023. It is now read-only.

Log total time for running tye init and tye deploy #91

Closed
jkotalik opened this issue Mar 9, 2020 · 6 comments
Closed

Log total time for running tye init and tye deploy #91

jkotalik opened this issue Mar 9, 2020 · 6 comments
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
backlog

Comments

@jkotalik
Copy link
Contributor

jkotalik commented Mar 9, 2020

Like dotnet build, printing the total runtime would be good for diagnostics.
@jkotalik jkotalik added the enhancement New feature or request label Mar 9, 2020
@davidfowl
Copy link
Member

Total time for tye run isn't useful and tye init might be more useful

@jkotalik jkotalik changed the title Log total time for running tye init and tye run Log total time for running tye init and tye deploy Mar 9, 2020
@jkotalik
Copy link
Contributor Author

jkotalik commented Mar 9, 2020

I meant deploy, not run.

@rynowak
Copy link
Member

rynowak commented Mar 10, 2020

Is it for us? Or for users?

@jkotalik
Copy link
Contributor Author

Users and maybe for us, but we can track performance of those commands in different ways. Knowing how long deploying or initialize takes is a nice metric to know, and it would be a fairly small change.

@jkotalik jkotalik added the good first issue Good for newcomers label Mar 19, 2020
@andresrsanchez
Copy link

Is something like this enough?

https://github.com/microsoft/msbuild/blob/2d82e1a861d890fce68c8e2d42b569e5bbaf5687/src/Build/Logging/LogFormatter.cs#L52

@jkotalik
Copy link
Contributor Author

Yeah that seems okay. I think just outputting the total runtime in seconds/milliseconds is better though, as it matches dotnet build.

Are you interested in doing this change? Feel free to make a PR if so 😄

@rynowak rynowak added this to the backlog milestone Apr 20, 2020
NileshGule added a commit to NileshGule/tye that referenced this issue May 24, 2020
@NileshGule
Fixes dotnet#91 Added timespan for execution of the Deploy command
f309cc6
NileshGule added a commit to NileshGule/tye that referenced this issue May 24, 2020
@NileshGule
Fixes dotnet#91 Added timespan for execution of the Undeploy and Init…
09ea9dc 
… command
NileshGule added a commit to NileshGule/tye that referenced this issue May 30, 2020
@NileshGule
Fixes dotnet#91 Added timespan for execution of the Deploy command
4ce1970
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
backlog
Development

No branches or pull requests
4 participants
@davidfowl @rynowak @jkotalik @andresrsanchez