Skip to content

Exclude reference packages from CG #1134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 28, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 3 additions & 13 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -98,19 +98,9 @@ a new targeting pack is needed, please [open a new issue](#filing-issues) to dis

## Vulnerable Packages

CVEs may exist for reference packages included in this repo. If they are mitigated by a newer version, the
newer version should be added, the vulnerable version should be removed (only if there are no product repo
references to it), and references to the vulnerable package within other reference packages should be upgraded.
A comment should be added to indicate when packages were manually upgraded in both the csproj and nuspec files.

``` xml
<!-- Manual upgrade from 4.3.0 to address CVE-2017-0247 -->
<PackageReference Include="System.Net.Security" Version="4.3.1" />
```

All packages that contain a manually upgraded reference must be added to the eng/build.props as a
DependencyPackageProjects in order to prevent the n-1 version from getting loaded which would still
reference the vulnerable version.
CVEs may exist for reference packages included in this repo. Because the packages do not contain any
implementation, they do not pose a security risk. CG is configured in this repo to ignore the reference
packages. If product repos migrate off these vulnerable packages, they can be [removed](#cleanup).

## Filing Issues

Expand Down
7 changes: 7 additions & 0 deletions azure-pipelines/builds/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,13 @@ extends:
template: azure-pipelines/MicroBuild.1ES.Official.yml@MicroBuildTemplate
parameters:
sdl:
componentgovernance:
verbosity: Verbose
# All of the SBRPs must be ignored because it is possible some of them are for vulnerable versions.
# Because they are reference only packages they are not vulnerable themselves.
ignoreDirectories: |
artifacts/sb,
src/referencePackages
policheck:
enabled: true
sourceAnalysisPool:
Expand Down