Skip to content

Skip failing dotnet-watch tests #49357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 12, 2025
Merged

Conversation

v-wuzhai
Copy link
Contributor

No description provided.

@v-wuzhai v-wuzhai marked this pull request as ready for review June 12, 2025 07:39
@Copilot Copilot AI review requested due to automatic review settings June 12, 2025 07:39
@v-wuzhai v-wuzhai requested review from tmat, arunchndr and a team as code owners June 12, 2025 07:39
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR temporarily skips several failing dotnet-watch tests, referencing a known issue in the dotnet/sdk repository.

  • Several [Theory] and [Fact] tests in HotReload/RuntimeProcessLauncherTests.cs are now marked with a Skip attribute.
  • Multiple tests in HotReload/ApplyDeltaTests.cs are similarly skipped to work around the issue.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
test/dotnet-watch.Tests/HotReload/RuntimeProcessLauncherTests.cs Marked four tests as skipped using the Skip attribute referencing the known issue
test/dotnet-watch.Tests/HotReload/ApplyDeltaTests.cs Marked five tests as skipped with the Skip attribute to bypass failing scenarios
Comments suppressed due to low confidence (2)

test/dotnet-watch.Tests/HotReload/RuntimeProcessLauncherTests.cs:137

  • Tests are being skipped due to a known issue, which lowers test coverage; consider adding a TODO comment or tracking issue reference to re-enable these tests once the issue is resolved.
[Theory(Skip = "https://github.com/dotnet/sdk/issues/49307")]

test/dotnet-watch.Tests/HotReload/ApplyDeltaTests.cs:108

  • Skipping tests in this file can reduce overall test coverage; consider adding a note to track when these tests should be re-enabled once the referenced issue is fixed.
[Fact(Skip = "https://github.com/dotnet/sdk/issues/49307")]

@v-wuzhai v-wuzhai merged commit 34ae4f2 into main Jun 12, 2025
30 checks passed
@v-wuzhai v-wuzhai deleted the dev/Jason/skip-dotnet-watch-tests branch June 12, 2025 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants