Adjust IsTestProject hacks to not include MTP
#49085
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adjusts test project conditions so that projects using the Microsoft Testing Platform (MTP) are no longer treated as standard test projects. The changes introduce a new property (_IsVSTestOnlyTestProject) and update existing conditions in the targets file to use this property.
- Introduces _IsVSTestOnlyTestProject to differentiate test projects from MTP projects.
- Updates condition checks for IsRidAgnostic, ValidateExecutableReferencesMatchSelfContained, and ShouldBeValidatedAsExecutableReference.
| @@ -97,6 +97,7 @@ Copyright (c) .NET Foundation. All rights reserved. | |||
| <_DefaultUserProfileRuntimeStorePath Condition="$([MSBuild]::IsOSPlatform(`Windows`))">$(USERPROFILE)</_DefaultUserProfileRuntimeStorePath> | |||
| <_DefaultUserProfileRuntimeStorePath>$([System.IO.Path]::Combine($(_DefaultUserProfileRuntimeStorePath), '.dotnet', 'store'))</_DefaultUserProfileRuntimeStorePath> | |||
| <UserProfileRuntimeStorePath Condition="'$(UserProfileRuntimeStorePath)' == ''">$(_DefaultUserProfileRuntimeStorePath)</UserProfileRuntimeStorePath> | |||
| <_IsVSTestOnlyTestProject Condition="'$(IsTestProject)' == 'true' AND '$(IsTestingPlatformApplication)' != 'true'">true</_IsVSTestOnlyTestProject> | |||
There was a problem hiding this comment.
[nitpick] Consider adding an inline comment explaining the purpose of the new _IsVSTestOnlyTestProject property, clarifying that it excludes MTP projects from test-specific conditions.
Copilot uses AI. Check for mistakes.
| @@ -114,7 +115,7 @@ Copyright (c) .NET Foundation. All rights reserved. | |||
| <!-- Set the IsRidAgnostic property if this project should NOT accept global RuntimeIdentifier and SelfContained | |||
| property values from referencing projects. --> | |||
| <PropertyGroup Condition="'$(IsRidAgnostic)' == ''"> | |||
| <IsRidAgnostic Condition="('$(_IsExecutable)' == 'true' And '$(IsTestProject)' != 'true') Or | |||
| <IsRidAgnostic Condition="('$(_IsExecutable)' == 'true' And '$(_IsVSTestOnlyTestProject)' != 'true') Or | |||
There was a problem hiding this comment.
[nitpick] Review and update any nearby inline comments to ensure they accurately reflect the change from IsTestProject to _IsVSTestOnlyTestProject for non-MTP test projects.
Copilot uses AI. Check for mistakes.
Fixes #49063