fix(templates): resolve gitattributes template generation #49078
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds the missing .gitattributes template under the Common ItemTemplates feed and corrects its filename generation for .NET SDK 10.
- Introduces a full
.gitattributestemplate file for text/binary attribute defaults - Verifies correct output filename when running
dotnet new gitattributes - May need analogous updates for other supported SDK versions
Comments suppressed due to low confidence (2)
template_feed/Microsoft.DotNet.Common.ItemTemplates/content/Gitattributes/.gitattributes:1
- This new template file isn’t covered by any automated tests. Consider adding a unit or integration test to verify that
dotnet new gitattributesgenerates the correct file contents across supported SDK versions.
## Set Git attributes for paths including line ending
template_feed/Microsoft.DotNet.Common.ItemTemplates/content/Gitattributes/.gitattributes:23
- [nitpick] You’ve listed both lowercase and uppercase extensions separately (e.g.,
*.docand*.DOC). Since Git attribute patterns are case-insensitive by default on many platforms, consider consolidating these entries or adding a comment to explain the distinction.
*.DOC diff=astextplain
MiYanni
approved these changes
May 20, 2025
There was a problem hiding this comment.
Copying the text out of the HTML:
template_feed/Microsoft.DotNet.Common.ItemTemplates/content/Gitattributes/.gitattrbutestemplate_feed/Microsoft.DotNet.Common.ItemTemplates/content/Gitattributes/.gitattributes
The problem was the i was missing from attributes. I didn't even see this at first. It wasn't mentioned in the PR description. Change looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Simple fix to the Gitattributes template so it generates the correct filename, i.e.:
.gitattrbutes => .gitattributes
Notice the addition of an
iin attributes.Verified and tested myself locally for .NET 10 fix. May need to be fixed on other in-support versions of the SDK as well?
Relevant links
Addresses #49077