Enable arm64 DEB tests #48319
Merged
Enable arm64 DEB tests #48319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
eng/pipelines/templates/steps/vmr-validate-installers.yml:38
- The unconditional addition of the test flags for RPM and DEB packages may result in running these tests on non-arm64 Linux builds, which deviates from the previous conditional behavior. Confirm that this change is intentional and that it does not inadvertently impact x64 builds.
+ /p:TestRpmPackages=true \
eng/pipelines/templates/stages/vmr-validation.yml:84
- While increasing the timeout to 60 minutes is appropriate for the slower arm64 tests, verify that this change integrates well with overall pipeline resource management.
+ timeoutInMinutes: 60
ViktorHofer
approved these changes
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a full set of arm64 DEB packages. This PR enables installer testing on Debian arm64 distros.
Arm64 tests are slower and they are now running close to the current timeout limit of 30 minutes. This PR also increases the timeout to 60 minutes.
Verification run: https://dev.azure.com/dnceng/internal/_build/results?buildId=2682358&view=results