[dotnet test for MTP] Throw exception if the project doesn't produce executable #48065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
There was a problem hiding this comment.
Pull Request Overview
This PR changes the behavior of dotnet test for Microsoft.Testing.Platform projects by explicitly throwing an exception when a test project doesn’t produce an executable rather than attempting a fallback execution method.
- Replaces the fallback to dotnet run with an exception throw in TestApplication.cs.
- Removes the BuildArgsWithDotnetRun method from TestApplication.cs and related constants from CliConstants.cs.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Cli/dotnet/Commands/Test/TestApplication.cs | Replaced fallback dotnet run execution with a clear exception for non-executable test projects and removed the redundant BuildArgsWithDotnetRun method. |
| src/Cli/dotnet/Commands/Test/CliConstants.cs | Removed constants that were used in the fallback execution logic, aligning with the new exception-based behavior. |
Co-authored-by: Copilot <[email protected]>
Youssef1313
commented
Apr 1, 2025
Youssef1313
commented
Apr 1, 2025
|
Build is green but is old. Kicking a new build. |
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
nohwnd
approved these changes
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think this should happen, or is a case we should support. So I think better to explicitly throw exception for now, and iterate later if there are user reports indicating valid use cases. But so far I can't see any valid use case.